Skip to content

Close second /audit-plugin pass: MultiEdit hook gap + four skill-gap skills - #5

Merged
AgenticPawan merged 2 commits into
masterfrom
remediation/critical-review-2026-07
Jul 13, 2026
Merged

Close second /audit-plugin pass: MultiEdit hook gap + four skill-gap skills#5
AgenticPawan merged 2 commits into
masterfrom
remediation/critical-review-2026-07

Conversation

@AgenticPawan

Copy link
Copy Markdown
Owner

Remediates the findings from the second pre-submission /audit-plugin pass. node scripts/validate.mjs exits 0 with no warnings.

Vulnerability (Medium) — MultiEdit bypassed the security hooks

plugins/pilot-core/hooks/hooks.json scoped both the PreToolUse (secret-guard, dangerous-patterns) and PostToolUse (formatter) matchers to Write|Edit, while the hook scripts handle — and are tested for — a MultiEdit payload. A real MultiEdit write therefore never fired the guards, so a secret introduced via MultiEdit was not blocked. Both matchers are now Write|Edit|MultiEdit, aligning the enforcement floor with the capability the tests already assert.

Standards — stale submission pointer

SUBMISSION.json pinned a commit 46 revisions behind HEAD. Re-stamped to the remediation content commit (6ae74d5) in a metadata-only follow-up commit.

Skill gaps — four new skills (house style: Standard-ID table + Check A–F, BAD/GOOD)

Skill Plugin IDs Why
azure-container-apps pilot-azure ACA-* ACA/App Service compute host the AKS checks don't cover
azure-edge-waf pilot-azure AFW-* Edge Web Application Firewall (Front Door / App Gateway)
fullstack-e2e-testing pilot-core E2E-* Real-browser cross-stack journey tier
data-residency-compliance pilot-core DRC-* Where regulated data may legally live/move

Also killed the azure-waf-review (Well-Architected Framework) vs azure-edge-waf (Web Application Firewall) name collision — azure-waf-review now carries a disambiguation note.

Wiring

  • infra-reviewer: ACA-/AFW-/DRC-* added to the standard-ID list, skill inventory, review categories R/S/T, severity map, and finding format.
  • fullstack-reviewer: cites fullstack-e2e-testing (E2E-001/002) for cross-layer journeys with no end-to-end coverage.
  • Version bumps: pilot-core 0.27.0 → 0.28.0, pilot-azure 0.18.0 → 0.19.0; new keywords; README counts (22→24, 14→16); dated CHANGELOG entry.

Notes for the reviewer

  • SUBMISSION.json references 6ae74d5 (the content commit), not the tip ced742f (the stamp itself) — a commit can't hash-reference itself, so the pointer targets the commit holding the full validated tree.
  • The two Low wiring findings from the audit needed no code change (the /fsp-build cross-plugin dependency is intentional and already handled by a graceful availability check), and the /pilot-*-prefix item was not a real violation (project is consistently /fsp-*).

🤖 Generated with Claude Code

AgenticPawan and others added 2 commits July 13, 2026 09:06
…skill-gap skills

Second pre-submission /audit-plugin pass remediation.

Vulnerability (Medium): hooks/hooks.json scoped both PreToolUse (secret-guard,
dangerous-patterns) and PostToolUse (formatter) matchers to "Write|Edit" while the
scripts handle — and are tested for — a MultiEdit payload. A real MultiEdit write
never fired the guards, so a secret introduced via MultiEdit was not blocked. Both
matchers are now "Write|Edit|MultiEdit".

Skill gaps (four new skills, matching house style):
- azure-container-apps (pilot-azure, ACA-*): ACA/App Service compute host the
  azure-aks-governance Kubernetes checks don't cover.
- azure-edge-waf (pilot-azure, AFW-*): edge Web Application Firewall (Front Door /
  App Gateway); disambiguated from azure-waf-review (Well-Architected Framework),
  which now carries a clarifying note.
- fullstack-e2e-testing (pilot-core, E2E-*): real-browser cross-stack journey tier.
- data-residency-compliance (pilot-core, DRC-*): where regulated data may legally live.

Wiring: infra-reviewer gains ACA-*/AFW-*/DRC-* in its ID list, skill inventory,
categories R/S/T, severity map, and finding format; fullstack-reviewer cites
fullstack-e2e-testing for uncovered cross-layer journeys. Version bumps
(pilot-core 0.27.0->0.28.0, pilot-azure 0.18.0->0.19.0), keywords, README counts,
and a CHANGELOG entry. validate.mjs exits 0 with no warnings.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Was pinned 46 commits behind HEAD (Standards finding). Now points at 6ae74d5,
the commit carrying all four skill-gap skills and the MultiEdit hook fix. This
stamp commit is metadata-only; the referenced commit holds the full validated tree.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@AgenticPawan
AgenticPawan merged commit 57e49fd into master Jul 13, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant