Close second /audit-plugin pass: MultiEdit hook gap + four skill-gap skills - #5
Merged
Merged
Conversation
…skill-gap skills Second pre-submission /audit-plugin pass remediation. Vulnerability (Medium): hooks/hooks.json scoped both PreToolUse (secret-guard, dangerous-patterns) and PostToolUse (formatter) matchers to "Write|Edit" while the scripts handle — and are tested for — a MultiEdit payload. A real MultiEdit write never fired the guards, so a secret introduced via MultiEdit was not blocked. Both matchers are now "Write|Edit|MultiEdit". Skill gaps (four new skills, matching house style): - azure-container-apps (pilot-azure, ACA-*): ACA/App Service compute host the azure-aks-governance Kubernetes checks don't cover. - azure-edge-waf (pilot-azure, AFW-*): edge Web Application Firewall (Front Door / App Gateway); disambiguated from azure-waf-review (Well-Architected Framework), which now carries a clarifying note. - fullstack-e2e-testing (pilot-core, E2E-*): real-browser cross-stack journey tier. - data-residency-compliance (pilot-core, DRC-*): where regulated data may legally live. Wiring: infra-reviewer gains ACA-*/AFW-*/DRC-* in its ID list, skill inventory, categories R/S/T, severity map, and finding format; fullstack-reviewer cites fullstack-e2e-testing for uncovered cross-layer journeys. Version bumps (pilot-core 0.27.0->0.28.0, pilot-azure 0.18.0->0.19.0), keywords, README counts, and a CHANGELOG entry. validate.mjs exits 0 with no warnings. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Was pinned 46 commits behind HEAD (Standards finding). Now points at 6ae74d5, the commit carrying all four skill-gap skills and the MultiEdit hook fix. This stamp commit is metadata-only; the referenced commit holds the full validated tree. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remediates the findings from the second pre-submission
/audit-pluginpass.node scripts/validate.mjsexits 0 with no warnings.Vulnerability (Medium) — MultiEdit bypassed the security hooks
plugins/pilot-core/hooks/hooks.jsonscoped both the PreToolUse (secret-guard, dangerous-patterns) and PostToolUse (formatter) matchers toWrite|Edit, while the hook scripts handle — and are tested for — aMultiEditpayload. A realMultiEditwrite therefore never fired the guards, so a secret introduced via MultiEdit was not blocked. Both matchers are nowWrite|Edit|MultiEdit, aligning the enforcement floor with the capability the tests already assert.Standards — stale submission pointer
SUBMISSION.jsonpinned a commit 46 revisions behind HEAD. Re-stamped to the remediation content commit (6ae74d5) in a metadata-only follow-up commit.Skill gaps — four new skills (house style: Standard-ID table + Check A–F, BAD/GOOD)
azure-container-appsazure-edge-waffullstack-e2e-testingdata-residency-complianceAlso killed the
azure-waf-review(Well-Architected Framework) vsazure-edge-waf(Web Application Firewall) name collision —azure-waf-reviewnow carries a disambiguation note.Wiring
infra-reviewer: ACA-/AFW-/DRC-* added to the standard-ID list, skill inventory, review categories R/S/T, severity map, and finding format.fullstack-reviewer: citesfullstack-e2e-testing(E2E-001/002) for cross-layer journeys with no end-to-end coverage.Notes for the reviewer
SUBMISSION.jsonreferences6ae74d5(the content commit), not the tipced742f(the stamp itself) — a commit can't hash-reference itself, so the pointer targets the commit holding the full validated tree./fsp-buildcross-plugin dependency is intentional and already handled by a graceful availability check), and the/pilot-*-prefix item was not a real violation (project is consistently/fsp-*).🤖 Generated with Claude Code