feat(reports): add reports view with empty/error states, live region, and memoized rows - #618
Merged
mikewheeleer merged 1 commit intoJul 30, 2026
Conversation
… and memoized rows Closes Agentpay-Org#505 Closes Agentpay-Org#506 Closes Agentpay-Org#507 Closes Agentpay-Org#508
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
No
reportspage/component existed in the repo. Issues #505-#508 each describe an incremental slice (empty/error states, an ARIA live region, tests, memoization) of a reports view that would need to already exist, so this builds the minimal view those issues collectively assume, in one PR — same shape as #614 (transactions) and #616 (onboarding):src/app/reports/page.tsx— fetches/api/v1/reportsvia the existinguseApihookSpinner), error (ErrorMessagewithonRetry), and empty (EmptyState) states (Add explicit empty and error states to the reports view #505)role="status" aria-live="polite"region announcing loading/error/empty/loaded transitions (Announce reports updates through an ARIA live region #506)ReportRowwrapped inmemo(Memoize reports rendering to avoid re-renders #508)pageTitles.reportsentry + route layoutNo separate docs issue exists for reports (unlike transactions/onboarding), so this PR is self-contained.
Tests (#507)
page.test.tsx: loading spinner, rendering rows once loaded, empty state, error state with retry button, retry re-fetches and recovers, and the live region's text updates across state transitions. All 6 pass locally.Test output
Same pre-existing, unrelated
main-at-HEADtsc --noEmiterrors noted in #614/#616.npx eslint src/app/reports src/app/pageTitles.tsis clean.Closes #505
Closes #506
Closes #507
Closes #508