[16.0][FIX] purchase_request_operating_unit: fix all-OU access group bypass - #1291
Merged
Merged
Conversation
Convert global OU record rules to non-global (group_purchase_request_user) so the all-OU bypass group in purchase_request_operating_unit_access_all can OR-override them via standard Odoo non-global rule mechanics. Replace hacky <function> domain patch with proper bypass ir.rule records.
n3n
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ir_rule_purchase_request_operating_unitsandir_rule_purchase_request_line_allowed_operating_unitsfromglobal=Trueto non-global rules scoped togroup_purchase_request_user, so Odoo's OR logic between non-global rules can be leveraged for bypass.<function>domain-patch hack inpurchase_request_operating_unit_access_allwith properir.rulebypass records (domain_force=[(1,'=',1)]) scoped togroup_all_ou_purchase_request.<data noupdate="1">in the access-all module.Test plan
-u purchase_request_operating_unit,purchase_request_operating_unit_access_allgroup_all_ou_purchase_request: can only see PRs in their own OUsgroup_all_ou_purchase_request: can see PRs across all OUs