Skip to content

global settings for Video Configuration#100

Merged
plutoless merged 5 commits intomasterfrom
Dev/GlobalSettings
Dec 16, 2020
Merged

global settings for Video Configuration#100
plutoless merged 5 commits intomasterfrom
Dev/GlobalSettings

Conversation

@xuchdeid
Copy link
Copy Markdown
Contributor

global settings for Video Configuration

@xuchdeid xuchdeid requested a review from plutoless December 15, 2020 11:44
CODE_SIGN_STYLE = Automatic;
COMBINE_HIDPI_IMAGES = YES;
DEVELOPMENT_TEAM = GM72UGLGZW;
DEVELOPMENT_TEAM = Y695MMFA83;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could remove project file in commit list

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

签名不要改,会影响CI

return res.name()
}))
resolutionPicker.selectItem(at: Configs.defaultResolutionIdx)
resolutionPicker.selectItem(at: GlobalSettings.shared.settings["resolution"]!.selectedOption().value as! Int)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

建议用guard let, 少用!

Copy link
Copy Markdown
Contributor

@plutoless plutoless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

有没有可能把设置做成单独的按钮而不是作为左边菜单里的一部分?现在这样看起来有些奇怪

@plutoless plutoless merged commit 4c54c47 into master Dec 16, 2020
@plutoless plutoless deleted the Dev/GlobalSettings branch December 16, 2020 16:05
alienzh pushed a commit that referenced this pull request Feb 12, 2026
global settings for Video Configuration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants