Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces new Multipath and Simulcast features to the Windows APIExample app, updating language files, resource IDs, stdafx configurations, and integrating two new dialogs into the main UI.
- Add Chinese and English translations for Multipath and Simulcast
- Define new event IDs and language keys in
stdafx - Create
CMultipathDlgandCSimulcastDlgand wire them intoAPIExampleDlg
Reviewed Changes
Copilot reviewed 53 out of 53 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| windows/APIExample/APIExample/zh-cn.ini | Add Chinese entries for Beauty.Face.2, Multipath, and Simulcast |
| windows/APIExample/APIExample/en.ini | Add English entries for Multipath and Simulcast (removed one) |
| windows/APIExample/APIExample/stdafx.h | Define EID_MULTIPATH_STATS and EID_NETWORK_TYPE_CHANGED |
| windows/APIExample/APIExample/stdafx.cpp | Declare beautyFace2, Multipath, advancedSimulcast arrays |
| windows/APIExample/APIExample/resource.h | Add resource IDs for Multipath and Simulcast dialogs |
| windows/APIExample/APIExample/Language.h | Add externs for new language keys |
| windows/APIExample/APIExample/Advanced/Multipath/CMultipathDlg.* | Implement Multipath dialog and event handling |
| windows/APIExample/APIExample/Advanced/Simulcast/CSimulcastDlg.* | Implement Simulcast dialog and event handling |
| windows/APIExample/APIExample/APIExampleDlg.* | Integrate Multipath and Simulcast dialogs into main UI |
Comments suppressed due to low confidence (3)
windows/APIExample/APIExample/en.ini:321
- The mapping for
CrossChannel.Ctrl.UpdateMediaRelaywas removed, breaking the English translation for that key; please restore it.
CrossChannel.Ctrl.StopMediaRelay = StopMediaRelay
windows/APIExample/APIExample/stdafx.cpp:341
- [nitpick] The variable
Multipathstarts with an uppercase letter, whereas other keys use lowercase (e.g.,beautyFace2,advancedSimulcast); consider renaming tomultipathfor consistency.
wchar_t Multipath[INFO_LEN] = { 0 };
windows/APIExample/APIExample/Advanced/Multipath/CMultipathDlg.cpp:450
- The new Multipath feature posts stats to the UI but no automated tests cover this behavior; consider adding unit or integration tests to validate
onMultipathStatshandling.
MultipathStats* stats = (MultipathStats*)wParam;
Comment on lines
+39
to
+41
| RemoteVideoStats* s = new RemoteVideoStats; | ||
| *s = stats; | ||
| ::PostMessage(m_hMsgHanlder, WM_MSGID(EID_REMOTE_VIDEO_STATS), (WPARAM)s, 0); |
There was a problem hiding this comment.
A RemoteVideoStats object is allocated and posted but never deleted in OnEIDRemoteVideoStats, leading to a memory leak; either delete it after use or use a stack-based object.
Suggested change
| RemoteVideoStats* s = new RemoteVideoStats; | |
| *s = stats; | |
| ::PostMessage(m_hMsgHanlder, WM_MSGID(EID_REMOTE_VIDEO_STATS), (WPARAM)s, 0); | |
| RemoteVideoStats s = stats; | |
| ::PostMessage(m_hMsgHanlder, WM_MSGID(EID_REMOTE_VIDEO_STATS), (WPARAM)&s, 0); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.