Conversation
Import type { Express, Router } from "express";
^^^^^^^
We reference express types, but we don't have it as a dependency in our
library
However, when the user uses the middleware, express will be installed...
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
timokoessler
approved these changes
May 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We replace
TS_EXPECT_TYPES_ERROR_OPTIONAL_DEPENDENCYwith@ts-expect-errorin our build script. We expect an error if e.g. express is installed (since we expose middleware for a few frameworks).If the user has
"skipLibCheck": truein their tsconfig.json, TypeScript won't type check our library declaration files.When the user has
expressinstalled andskipLibCheckisfalse, there is no error but since TypeScript expects an error...That's why I replaced
@ts-expect-errorwith@ts-ignore