Fix multiple bugs: type safety, defaults, validation, thread safety - #1
Closed
Aitgray wants to merge 1 commit into
Closed
Fix multiple bugs: type safety, defaults, validation, thread safety#1Aitgray wants to merge 1 commit into
Aitgray wants to merge 1 commit into
Conversation
Aitgray
commented
Apr 9, 2026
Aitgray
commented
Owner
- Raise UniverseSchemaError on empty YAML instead of returning None from load_universe
- Add missing Any import in factions/ai.py for correct type annotations
- Fix growth_rate default in save_load.py from_dict (0.0 -> 0.01) to match Population dataclass
- Move cached_nodes update inside lock in update_node_positions to prevent race conditions
- Add try/except for int() conversion in /sim/step and /sim/rewind endpoints (returns 400)
- Add response.ok checks in frontend postJson and fetchSimState to handle HTTP errors
- Raise UniverseSchemaError on empty YAML instead of returning None from load_universe - Add missing Any import in factions/ai.py for correct type annotations - Fix growth_rate default in save_load.py from_dict (0.0 -> 0.01) to match Population dataclass - Move cached_nodes update inside lock in update_node_positions to prevent race conditions - Add try/except for int() conversion in /sim/step and /sim/rewind endpoints (returns 400) - Add response.ok checks in frontend postJson and fetchSimState to handle HTTP errors Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.