Skip to content

Conversation

@macrat
Copy link
Contributor

@macrat macrat commented May 2, 2019

Updated dependencies with ncu and npm audit fix.

I edited two tests for testing this changeset

  • test251: seems to always fail because test/test251.xlsx is not included in the repository.
  • test383: fails if execution too fast.

@mathiasrw
Copy link
Member

Thank you! Ill get the merge conflicts working. Im so sorry it took so long for me to discover your PR.

@macrat macrat force-pushed the update-dependencies branch from 6c34acc to a06a7f2 Compare June 4, 2019 04:04
@macrat
Copy link
Contributor Author

macrat commented Jun 4, 2019

I was tried to merge (and fail).

git reports conflicts on dist/ files those files are built by npm build.
Maybe this differences are caused by build tools.
my PR are updating build tools.

I want to re-make new PR for update dependencies if you agree.

@mathiasrw mathiasrw mentioned this pull request Sep 16, 2019
@mathiasrw
Copy link
Member

Thank you SO much. And sorry about the wayyyy looonnnggg reponse time.

I fixed the conflicts in #1133

@mathiasrw mathiasrw closed this Sep 16, 2019
mathiasrw added a commit that referenced this pull request Sep 16, 2019
All credits goes to @macrat

* Updated dependencies

* Fixed test 251/383

* Merged #1105

* Remove node 4 and 5 build support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants