Fix for issue with a chain of OUTER JOINs #1105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # dist/alasql-worker.js # dist/alasql-worker.min.js # dist/alasql.fs.js # dist/alasql.js # dist/alasql.min.js # test/test800.js
Codecov Report
@@ Coverage Diff @@
## develop #1105 +/- ##
===========================================
+ Coverage 70.67% 70.68% +<.01%
===========================================
Files 1 1
Lines 14198 14201 +3
Branches 4792 4790 -2
===========================================
+ Hits 10035 10038 +3
Misses 4163 4163
Continue to review full report at Codecov.
|
Member
|
You are awesome! Thank you so much. I am very sorry it took me so long to see your PR. Big thank you for digging into this ooooold old old issue. 🎉 |
Member
|
I will release a new version in the weekend with this. |
Contributor
Author
|
Thank you! |
macrat
added a commit
to macrat/alasql
that referenced
this pull request
Jun 3, 2019
Fix for issue with a chain of OUTER JOINs (AlaSQL#1105)
macrat
added a commit
to macrat/alasql
that referenced
this pull request
Jun 3, 2019
macrat
added a commit
to macrat/alasql
that referenced
this pull request
Jun 4, 2019
This was referenced Apr 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for the time you are putting into AlaSQL!
Example:
SELECT * FROM ? T1 ' +
'OUTER JOIN ? T2 ON T1.id = T2.id ' +
'OUTER JOIN ? T3 ON T1.id = T3.id OR T2.id = T3.id ' +
'OUTER JOIN ? T4 ON T1.id = T4.id OR T2.id = T4.id OR T3.id = T4.id
Expected: rows from all tables are joined.
Actual: only all rows from T1 and T2 are present; rows from T3 and T4 that do not match T1 and T2 are missing.
See test801.js