Skip to content

Conversation

@mathiasrw
Copy link
Member

Thank you for the time you are putting into AlaSQL!

JoshuaPoon1 and others added 3 commits November 30, 2025 23:14
Edited utils.glob and utils.like to improve readability. Proved comments to help reader traverse through code. 

Also rename:
und ----> undefinedOrValue
n2u ——> nanToUndefined
@mathiasrw
Copy link
Member Author

@copilot


  Running tests on alasql@4.10.1

  Environment detected: {
    "alasqlPath": "/home/runner/_work/alasql/alasql/dist",
    "isBrowser": false,
    "isCordova": false,
    "isMeteor": false,
    "isMeteorClient": false,
    "isMeteorServer": false,
    "isNode": true,
    "isWebWorker": false
}
/home/runner/_work/alasql/alasql/test

 Exception during run: ReferenceError: n2u is not defined
    at /home/runner/_work/alasql/alasql/dist/alasql.fs.js:9490:57
    at Array.forEach (<anonymous>)
    at yy.Select.compileSelect1 (/home/runner/_work/alasql/alasql/dist/alasql.fs.js:9252:15)
    at Select.compile (/home/runner/_work/alasql/alasql/dist/alasql.fs.js:7547:27)
    at alasql.dexec (/home/runner/_work/alasql/alasql/dist/alasql.fs.js:4860:38)
    at alasql.exec (/home/runner/_work/alasql/alasql/dist/alasql.fs.js:4796:17)
    at alasql (/home/runner/_work/alasql/alasql/dist/alasql.fs.js:137:17)
    at /home/runner/_work/alasql/alasql/test/test374.js:154:21
    at Array.forEach (<anonymous>)
    at Suite.<anonymous> (/home/runner/_work/alasql/alasql/test/test374.js:140:5)
    at Object.create (/home/runner/_work/alasql/alasql/node_modules/mocha/lib/interfaces/common.js:153:19)
    at context.describe.context.context (/home/runner/_work/alasql/alasql/node_modules/mocha/lib/interfaces/bdd.js:46:27)
    at Object.<anonymous> (/home/runner/_work/alasql/alasql/test/test374.js:7:1)
    at Module._compile (node:internal/modules/cjs/loader:1364:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1422:10)
    at Module.load (node:internal/modules/cjs/loader:1203:32)
    at Module._load (node:internal/modules/cjs/loader:1019:12)
    at ModuleWrap.<anonymous> (node:internal/modules/esm/translators:203:29)
    at ModuleJob.run (node:internal/modules/esm/module_job:195:25)
    at async ModuleLoader.import (node:internal/modules/esm/loader:337:24)
    at async importModuleDynamicallyWrapper (node:internal/vm/module:432:15)
    at async formattedImport (/home/runner/_work/alasql/alasql/node_modules/mocha/lib/nodejs/esm-utils.js:10:14)
    at async Object.tryImportAndRequire [as requireOrImport] (/home/runner/_work/alasql/alasql/node_modules/mocha/lib/nodejs/esm-utils.js:47:28)
    at async exports.loadFilesAsync (/home/runner/_work/alasql/alasql/node_modules/mocha/lib/nodejs/esm-utils.js:152:20)
    at async singleRun (/home/runner/_work/alasql/alasql/node_modules/mocha/lib/cli/run-helpers.js:168:3)
    at async exports.handler (/home/runner/_work/alasql/alasql/node_modules/mocha/lib/cli/run.js:379:5)
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
Error: Process completed with exit code 1.

Copy link
Contributor

Copilot AI commented Nov 30, 2025

@mathiasrw I've opened a new pull request, #2286, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot AI and others added 2 commits December 1, 2025 00:47
…, und)

Co-authored-by: mathiasrw <1063454+mathiasrw@users.noreply.github.com>
@mathiasrw mathiasrw merged commit a5f3e9b into develop Nov 30, 2025
10 checks passed
@mathiasrw mathiasrw deleted the cohelp/JoshuaPoon1/1878 branch November 30, 2025 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants