Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 30, 2025

Thank you for the time you are putting into AlaSQL!

Description

Runtime error ReferenceError: n2u is not defined caused by renamed utility functions missing backward compatibility aliases.

The functions n2u and und were renamed to nanToUndefined and undefinedOrValue for clarity, but references in src/424select.js and src/55functions.js still use the old names.

Fix: Added backward compatibility aliases:

var n2u = nanToUndefined; // Alias for backward compatibility
var und = undefinedOrValue; // Alias for backward compatibility

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI mentioned this pull request Nov 30, 2025
@mathiasrw mathiasrw marked this pull request as ready for review November 30, 2025 12:57
…, und)

Co-authored-by: mathiasrw <1063454+mathiasrw@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Nov 30, 2025

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • upload.wikimedia.org
    • Triggering command: /usr/local/bin/node /usr/local/bin/node node_modules/mocha/bin/mocha.js ./test --reporter dot --bail (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Fix reference error in AlaSQL tests Fix missing n2u and und function aliases causing runtime error Nov 30, 2025
Copilot AI requested a review from mathiasrw November 30, 2025 13:05
Copilot finished work on behalf of mathiasrw November 30, 2025 13:05
@mathiasrw mathiasrw merged commit fe55000 into cohelp/JoshuaPoon1/1878 Nov 30, 2025
2 checks passed
@mathiasrw mathiasrw deleted the copilot/sub-pr-2284 branch November 30, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants