improve upload and inspect page UX#1
Merged
Merged
Conversation
gurvinder
requested changes
May 21, 2026
Collaborator
gurvinder
left a comment
There was a problem hiding this comment.
Separate out code into commits, each "feature" or isolated functionality change should be its own commit so it can be independently rolled back without touching any other part of the code.
Example Commits:
- Smart default — pick the first real DB, not "Create New"
- border-top rgba(128, 128, 128, 0.3) and background-color rgba(128, 128, 128, 0.06) change
- etc...
gurvinder
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The vector database dropdown defaulted to "Create New" instead of the first existing database, document deletion was implemented in the backend code but never exposed in the UI, empty vector stores showed no feedback, and the table CSS used hardcoded dark-theme colors that looked off in light mode.
The Inspect sub-pages (Models, Providers, Vector Databases, Shields) had no error handling: if the LlamaStack backend was unreachable, the pages would crash with a raw Python traceback. Additionally, the Models page called models.list() twice per render, and the Providers table was hardcoded to 500px width.
Upload page changes:
_delete_file_from_vector_storeAPIrgba()values that adapt to both light and dark Streamlit themesst.warninginstead ofprint()to consoleInspect page changes:
try/exceptwith user-friendly error messagesst.spinnerloading indicators while data is being fetcheduse_container_width=Trueinstead of hardcodedwidth=500for responsive layoutmodels.list()twice per renderprovidersshadowed the function nameTests
Skipped tests:
test_chat_page_loads— requires full Streamlit app contexttest_maas_chat_completion_direct_mode— requires live MaaS model endpointtest_maas_model_selection— requires live MaaS model endpoint