Skip to content

Hide unresolved objects when owner filters are active on the Scene Explorer#337

Open
gwigz wants to merge 1 commit into
AlchemyViewer:developfrom
gwigz:gwigz/scene-explorer-owner-filter
Open

Hide unresolved objects when owner filters are active on the Scene Explorer#337
gwigz wants to merge 1 commit into
AlchemyViewer:developfrom
gwigz:gwigz/scene-explorer-owner-filter

Conversation

@gwigz

@gwigz gwigz commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

With an owner filter active and Full Region Coverage disabled, camming around streams new objects in whose ObjectProperties reply hasn't landed yet. The predicate deliberately let those rows pass ("can't judge what it doesn't know"), so every newly loaded object leaked into the filtered list regardless of owner, and child prims of an already-rejected linkset kept the folder visible the same way. Flag filters (e.g. Light) use local object data, which is why they were unaffected.

Fail the owner clause instead while props are unresolved. The props fetch is already queued when a row is built, and applying the reply dirties the row's filter state, so matching rows appear as their ownership resolves.

Fixes #335

With an owner filter active and Full Region Coverage disabled, camming
around streams new objects in whose ObjectProperties reply hasn't landed
yet. The predicate deliberately let those rows pass ("can't judge what it
doesn't know"), so every newly loaded object leaked into the filtered
list regardless of owner, and child prims of an already-rejected linkset
kept the folder visible the same way. Flag filters (e.g. Light) use local
object data, which is why they were unaffected.

Fail the owner clause instead while props are unresolved. The props fetch
is already queued when a row is built, and applying the reply dirties the
row's filter state, so matching rows appear as their ownership resolves.

Fixes AlchemyViewer#335

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@gwigz gwigz force-pushed the gwigz/scene-explorer-owner-filter branch from 1fee7ed to d9fd88e Compare July 1, 2026 21:24
@coderabbitai

coderabbitai Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Warning

Review limit reached

@gwigz, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 58 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 1ada9d87-6cf2-4b4f-b2d2-2c24a81b5a07

📥 Commits

Reviewing files that changed from the base of the PR and between 43e3ae0 and d9fd88e.

📒 Files selected for processing (2)
  • indra/newview/alsceneexplorerpredicate.cpp
  • indra/newview/tests/alsceneexplorerpredicate_test.cpp

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Scene Explore doesn't apply Owner filter to newly loaded objects

1 participant