209 add data from the territorio folder #210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luabida
reviewed
Oct 21, 2024
Collaborator
There was a problem hiding this comment.
Is it really necessary to include a Database to download Territory data? Databases includes methods that have the same inputs and to generate the same outputs, but internally handles each db's specifications, as describe, format and get_files. It seems that Territory's implementation on online_data module can be done using only Directory. I'll include a comment in the file to explain more about it
Collaborator
Author
There was a problem hiding this comment.
maybe not. I just followed the pattern for other databases
luabida
approved these changes
Nov 11, 2024
|
🎉 This PR is included in version 0.15.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Almost done, Downloading is not working.
@luabida , can you take a look?