Skip to content

Scan - #168

Merged
AlexInLog merged 6 commits into
mainfrom
scan
Jul 12, 2022
Merged

Scan#168
AlexInLog merged 6 commits into
mainfrom
scan

Conversation

@AlexInLog

Copy link
Copy Markdown
Owner

No description provided.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-tidy found issue(s) with the introduced code (1/1)

Comment thread src/rpp/rpp/operators/scan.hpp Outdated
Comment thread src/samples/doxygen/scan.cpp Outdated
Comment thread src/samples/doxygen/scan.cpp Outdated
@codecov

codecov Bot commented Jul 12, 2022

Copy link
Copy Markdown

Codecov Report

Merging #168 (5aa16ad) into main (e681777) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #168   +/-   ##
=======================================
  Coverage   99.66%   99.67%           
=======================================
  Files          66       68    +2     
  Lines         909      921   +12     
=======================================
+ Hits          906      918   +12     
  Misses          3        3           
Impacted Files Coverage Δ
src/rpp/rpp/observables/interface_observable.hpp 100.00% <ø> (ø)
src/rpp/rpp/operators/fwd/scan.hpp 100.00% <100.00%> (ø)
src/rpp/rpp/operators/scan.hpp 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e681777...5aa16ad. Read the comment docs.

AlexInLog and others added 3 commits July 12, 2022 13:26
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-tidy found issue(s) with the introduced code (1/1)

Comment thread src/samples/doxygen/scan.cpp
Comment thread src/samples/doxygen/scan.cpp

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-tidy found issue(s) with the introduced code (1/1)

Comment thread src/samples/doxygen/scan.cpp
@github-actions

github-actions Bot commented Jul 12, 2022

Copy link
Copy Markdown
Contributor

Linux CLANG

Observable construction

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
Specific observable construction 0.38ns 0.345811 1.11 0.32ns
Dynamic observable construction 38.56ns 24.6349 1.57 23.08ns
Specific observable construction + as_dynamic 29.71ns 27.0911 1.10 25.60ns

Observable lift

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
Specific observable lift specific observer 72.84ns 67.5719 1.08 307.59ns
Specific observable lift dynamic observer 96.73ns 91.8006 1.05 306.15ns
Dynamic observable lift specific observer 176.10ns 143.088 1.23 341.49ns
Dynamic observable lift dynamic observer 197.69ns 153.66 1.29 325.91ns

Observable subscribe

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
Specific observable subscribe specific observer 46.48ns 42.4281 1.10 282.45ns
Specific observable subscribe dynamic observer 60.74ns 52.7599 1.15 308.92ns
Dynamic observable subscribe specific observer 126.32ns 102.612 1.23 349.45ns
Dynamic observable subscribe dynamic observer 116.97ns 98.9305 1.18 332.20ns

Observable subscribe #2

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
Specific observable subscribe lambda 43.82ns 42.3436 1.03 321.70ns
Dynamic observable subscribe lambda 127.15ns 98.003 1.30 360.98ns
Specific observable subscribe lambda without subscription 43.73ns 42.228 1.04 285.23ns
Dynamic observable subscribe lambda without subscription 132.24ns 97.958 1.35 364.62ns
Specific observable subscribe specific subscriber 17.06ns 13.846 1.23 230.60ns
Dynamic observable subscribe specific subscriber 75.52ns 67.6049 1.12 295.94ns
Specific observable subscribe dynamic observer 17.83ns 13.8666 1.29 243.26ns
Dynamic observable subscribe dynamic observer 63.41ns 58.637 1.08 263.47ns

Observer construction

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
Specific observer construction 0.70ns 0.347759 2.01 0.38ns
Dynamic observer construction 30.48ns 27.1313 1.12 22.32ns
Specific observer construction + as_dynamic 29.44ns 27.1233 1.09 18.81ns

OnNext

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
Specific observer OnNext 0.65ns 0.381536 1.70 0.67ns
Dynamic observer OnNext 2.07ns 1.384 1.50 1.95ns

Operators

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
map construction from observable via dot + subscribe 77.67ns 65.0871 1.19 255.80ns

Subscriber construction

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
Make subsriber 34.55ns 28.1738 1.23 71.55ns
Make copy of subscriber 18.49ns 13.8569 1.33 5.49ns
Transform subsriber to dynamic 41.98ns 40.4829 1.04 25.93ns

Subscription

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
composite_subscription create 32.79ns 28.7952 1.14 50.68ns
composite_subscription add 42.24ns 40.5514 1.04 21.92ns
composite_subscription unsubscribe 6.17ns 6.97585 0.88 9.87ns

foundamental sources

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
empty 20.42ns 13.8477 1.47 34.29ns
error 50.18ns 41.7355 1.20 79.83ns
never 17.57ns 13.8546 1.27 269.26ns

from

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
from vector with int 28.81ns 21.8688 1.32 60.58ns

just

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
just send int 24.53ns 13.8544 1.77 37.94ns
just send variadic 18.09ns 16.2953 1.11 51.04ns

merge

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
merge 38.04ns 14.2861 2.66 126.80ns
merge_with 101.87ns 66.0029 1.54 337.54ns

publish_subject callbacks

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
on_next 24.69ns 25.7494 0.96 11.03ns
on_error 2.42ns 1.75423 1.38 19.86ns
on_completed 2.04ns 1.44653 1.41 0.56ns

publish_subject routines

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
construct 171.90ns 146.603 1.17 200.58ns
get_observable 29.54ns 30.7133 0.96 49.18ns
get_subscriber 55.78ns 57.9049 0.96 14.51ns

Linux GCC

Observable construction

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
Specific observable construction 0.39ns 0.362944 1.08 0.39ns
Dynamic observable construction 22.35ns 22.5416 0.99 30.57ns
Specific observable construction + as_dynamic 24.23ns 20.9738 1.16 23.77ns

Observable lift

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
Specific observable lift specific observer 35.17ns 30.2712 1.16 435.80ns
Specific observable lift dynamic observer 33.88ns 36.4372 0.93 451.91ns
Dynamic observable lift specific observer 119.09ns 82.8215 1.44 507.02ns
Dynamic observable lift dynamic observer 82.44ns 71.6765 1.15 500.94ns

Observable subscribe

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
Specific observable subscribe specific observer 27.72ns 25.0345 1.11 414.35ns
Specific observable subscribe dynamic observer 26.42ns 27.7639 0.95 477.83ns
Dynamic observable subscribe specific observer 66.34ns 65.643 1.01 518.81ns
Dynamic observable subscribe dynamic observer 47.01ns 43.8692 1.07 464.83ns

Observable subscribe #2

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
Specific observable subscribe lambda 25.36ns 23.5699 1.08 491.68ns
Dynamic observable subscribe lambda 72.58ns 66.813 1.09 489.16ns
Specific observable subscribe lambda without subscription 29.00ns 26.5243 1.09 428.48ns
Dynamic observable subscribe lambda without subscription 70.02ns 67.932 1.03 499.39ns
Specific observable subscribe specific subscriber 7.58ns 4.50813 1.68 356.92ns
Dynamic observable subscribe specific subscriber 34.18ns 32.9842 1.04 419.42ns
Specific observable subscribe dynamic observer 5.67ns 4.47951 1.27 361.55ns
Dynamic observable subscribe dynamic observer 22.53ns 17.6021 1.28 409.63ns

Observer construction

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
Specific observer construction 0.41ns 0.400089 1.02 0.39ns
Dynamic observer construction 22.84ns 23.4625 0.97 24.68ns
Specific observer construction + as_dynamic 26.29ns 21.9579 1.20 23.77ns

OnNext

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
Specific observer OnNext 0.43ns 0.402289 1.07 0.39ns
Dynamic observer OnNext 7.17ns 2.31715 3.09 2.36ns

Operators

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
map construction from observable via dot + subscribe 21.24ns 17.6379 1.20 469.19ns

Subscriber construction

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
Make subsriber 31.10ns 26.1891 1.19 71.99ns
Make copy of subscriber 5.84ns 4.4015 1.33 5.56ns
Transform subsriber to dynamic 25.43ns 26.4924 0.96 36.85ns

Subscription

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
composite_subscription create 24.06ns 24.68 0.97 66.44ns
composite_subscription add 32.75ns 26.2935 1.25 19.06ns
composite_subscription unsubscribe 7.73ns 7.73201 1.00 13.35ns

foundamental sources

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
empty 4.66ns 4.17373 1.12 55.69ns
error 43.89ns 37.8645 1.16 102.03ns
never 4.92ns 4.13104 1.19 363.82ns

from

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
from vector with int 24.46ns 25.7375 0.95 82.37ns

just

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
just send int 6.22ns 4.20772 1.48 64.96ns
just send variadic 5.48ns 4.54348 1.21 63.81ns

merge

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
merge 6.16ns 4.20026 1.47 170.50ns
merge_with 52.36ns 45.9684 1.14 525.27ns

publish_subject callbacks

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
on_next 21.09ns 16.7739 1.26 12.48ns
on_error 0.83ns 1.15573 0.72 22.61ns
on_completed 1.09ns 1.56442 0.69 0.80ns

publish_subject routines

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
construct 203.54ns 123.304 1.65 236.50ns
get_observable 5.72ns 5.51949 1.04 59.19ns
get_subscriber 15.81ns 14.2513 1.11 27.47ns

Windows MSVC

Observable construction

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
Specific observable construction 2.17ns 1.89086 1.15 0.78ns
Dynamic observable construction 99.17ns 102.168 0.97 143.50ns
Specific observable construction + as_dynamic 97.94ns 103.321 0.95 143.91ns

Observable lift

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
Specific observable lift specific observer 167.83ns 170.711 0.98 1433.29ns
Specific observable lift dynamic observer 194.47ns 209.41 0.93 1407.00ns
Dynamic observable lift specific observer 279.97ns 330.929 0.85 1565.11ns
Dynamic observable lift dynamic observer 262.91ns 277.608 0.95 1387.80ns

Observable subscribe

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
Specific observable subscribe specific observer 120.90ns 132.805 0.91 1322.19ns
Specific observable subscribe dynamic observer 125.95ns 146.141 0.86 1319.57ns
Dynamic observable subscribe specific observer 248.97ns 272.697 0.91 1559.11ns
Dynamic observable subscribe dynamic observer 170.44ns 202.851 0.84 1347.50ns

Observable subscribe #2

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
Specific observable subscribe lambda 115.52ns 131.992 0.88 2092.73ns
Dynamic observable subscribe lambda 243.43ns 271.164 0.90 1527.26ns
Specific observable subscribe lambda without subscription 119.21ns 131.19 0.91 1375.32ns
Dynamic observable subscribe lambda without subscription 254.44ns 273.758 0.93 1666.68ns
Specific observable subscribe specific subscriber 19.72ns 20.9709 0.94 983.14ns
Dynamic observable subscribe specific subscriber 149.02ns 164.72 0.90 1200.67ns
Specific observable subscribe dynamic observer 19.86ns 21.6003 0.92 1045.38ns
Dynamic observable subscribe dynamic observer 72.11ns 80.797 0.89 1051.19ns

Observer construction

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
Specific observer construction 0.76ns 0.850058 0.90 2.06ns
Dynamic observer construction 101.29ns 103.439 0.98 142.30ns
Specific observer construction + as_dynamic 101.56ns 102.858 0.99 133.48ns

OnNext

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
Specific observer OnNext 0.75ns 0.840055 0.89 0.79ns
Dynamic observer OnNext 2.20ns 2.13188 1.03 2.60ns

Operators

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
map construction from observable via dot + subscribe 83.99ns 97.4894 0.86 1080.16ns

Subscriber construction

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
Make subsriber 98.55ns 110.575 0.89 375.68ns
Make copy of subscriber 15.57ns 21.0085 0.74 36.74ns
Transform subsriber to dynamic 106.56ns 131.197 0.81 173.79ns

Subscription

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
composite_subscription create 177.17ns 108.965 1.63 390.92ns
composite_subscription add 72.73ns 79.3119 0.92 75.07ns
composite_subscription unsubscribe 7.35ns 10.521 0.70 26.74ns

foundamental sources

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
empty 17.27ns 21.1162 0.82 213.56ns
error 53.32ns 59.2046 0.90 250.16ns
never 30.06ns 20.9006 1.44 905.60ns

from

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
from vector with int 101.28ns 103.754 0.98 314.67ns

just

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
just send int 23.04ns 25.1995 0.91 208.51ns
just send variadic 33.70ns 25.6769 1.31 245.08ns

merge

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
merge 38.65ns 40.6402 0.95 808.27ns
merge_with 347.93ns 358.969 0.97 1671.92ns

publish_subject callbacks

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
on_next 23.03ns 25.4188 0.91 37.25ns
on_error 2.70ns 3.90058 0.69 21.28ns
on_completed 2.48ns 3.17352 0.78 0.80ns

publish_subject routines

Table
Test Name Current, ns Prev, ns Ratio RxCpp current, ns
construct 376.02ns 367.273 1.02 681.47ns
get_observable 31.63ns 35.2949 0.90 178.98ns
get_subscriber 62.32ns 65.2222 0.96 106.44ns

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@AlexInLog
AlexInLog merged commit d896c7e into main Jul 12, 2022
@AlexInLog
AlexInLog deleted the scan branch July 12, 2022 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant