Resolve some linter/compiler warning messages

[tcw165]

No description provided.

[codecov]

Codecov Report

Merging #171 (d5665cc) into main (90921f3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #171   +/-   ##
=======================================
  Coverage   99.67%   99.67%           
=======================================
  Files          68       68           
  Lines         926      926           
=======================================
  Hits          923      923           
  Misses          3        3           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90921f3...d5665cc. Read the comment docs.

[github-actions]

Linux CLANG

Observable construction

Table

Test Name	Current, ns	Prev, ns	Ratio	RxCpp current, ns
Specific observable construction	0.40ns	0.335304	1.20	0.40ns
Dynamic observable construction	28.53ns	28.4565	1.00	25.19ns
Specific observable construction + as_dynamic	28.83ns	28.5061	1.01	25.05ns

Observable lift

Table

Test Name	Current, ns	Prev, ns	Ratio	RxCpp current, ns
Specific observable lift specific observer	78.16ns	70.411	1.11	291.22ns
Specific observable lift dynamic observer	105.31ns	94.816	1.11	309.09ns
Dynamic observable lift specific observer	160.96ns	153.61	1.05	341.72ns
Dynamic observable lift dynamic observer	176.96ns	162.813	1.09	322.76ns

Observable subscribe

Table

Test Name	Current, ns	Prev, ns	Ratio	RxCpp current, ns
Specific observable subscribe specific observer	49.20ns	43.9003	1.12	290.85ns
Specific observable subscribe dynamic observer	61.19ns	59.0615	1.04	301.42ns
Dynamic observable subscribe specific observer	111.75ns	111.064	1.01	334.85ns
Dynamic observable subscribe dynamic observer	117.87ns	108.872	1.08	316.82ns

Observable subscribe #2

Table

Test Name	Current, ns	Prev, ns	Ratio	RxCpp current, ns
Specific observable subscribe lambda	48.88ns	44.4734	1.10	291.86ns
Dynamic observable subscribe lambda	109.85ns	110.06	1.00	334.46ns
Specific observable subscribe lambda without subscription	49.13ns	44.559	1.10	285.65ns
Dynamic observable subscribe lambda without subscription	110.00ns	110.275	1.00	337.26ns
Specific observable subscribe specific subscriber	16.09ns	16.7579	0.96	221.19ns
Dynamic observable subscribe specific subscriber	77.64ns	78.014	1.00	272.00ns
Specific observable subscribe dynamic observer	16.08ns	16.7197	0.96	238.39ns
Dynamic observable subscribe dynamic observer	67.44ns	63.1808	1.07	261.45ns

Observer construction

Table

Test Name	Current, ns	Prev, ns	Ratio	RxCpp current, ns
Specific observer construction	0.80ns	0.67033	1.20	0.40ns
Dynamic observer construction	31.90ns	28.5061	1.12	19.66ns
Specific observer construction + as_dynamic	29.10ns	29.4772	0.99	19.72ns

OnNext

Table

Test Name	Current, ns	Prev, ns	Ratio	RxCpp current, ns
Specific observer OnNext	0.45ns	0.670444	0.67	0.44ns
Dynamic observer OnNext	2.90ns	1.67436	1.73	1.60ns

Operators

Table

Test Name	Current, ns	Prev, ns	Ratio	RxCpp current, ns
map construction from observable via dot + subscribe	75.57ns	71.4172	1.06	237.83ns

Subscriber construction

Table

Test Name	Current, ns	Prev, ns	Ratio	RxCpp current, ns
Make subsriber	32.55ns	32.4779	1.00	71.60ns
Make copy of subscriber	18.89ns	16.774	1.13	5.09ns
Transform subsriber to dynamic	47.23ns	43.7651	1.08	25.13ns

Subscription

Table

Test Name	Current, ns	Prev, ns	Ratio	RxCpp current, ns
composite_subscription create	33.48ns	32.5382	1.03	49.69ns
composite_subscription add	48.65ns	45.5498	1.07	20.84ns
composite_subscription unsubscribe	8.05ns	6.03531	1.33	13.66ns

foundamental sources

Table

Test Name	Current, ns	Prev, ns	Ratio	RxCpp current, ns
empty	16.12ns	16.7429	0.96	32.80ns
error	48.67ns	49.29	0.99	73.63ns
never	16.04ns	16.7603	0.96	229.57ns

from

Table

Test Name	Current, ns	Prev, ns	Ratio	RxCpp current, ns
from vector with int	25.72ns	26.8422	0.96	55.71ns

just

Table

Test Name	Current, ns	Prev, ns	Ratio	RxCpp current, ns
just send int	16.09ns	16.7451	0.96	31.31ns
just send variadic	18.94ns	16.7908	1.13	38.42ns

merge

Table

Test Name	Current, ns	Prev, ns	Ratio	RxCpp current, ns
merge	16.77ns	17.3627	0.97	122.81ns
merge_with	77.18ns	77.947	0.99	291.80ns

publish_subject callbacks

Table

Test Name	Current, ns	Prev, ns	Ratio	RxCpp current, ns
on_next	30.79ns	24.4837	1.26	8.91ns
on_error	2.18ns	2.42712	0.90	19.01ns
on_completed	1.69ns	1.72517	0.98	0.81ns

publish_subject routines

Table

Test Name	Current, ns	Prev, ns	Ratio	RxCpp current, ns
construct	171.76ns	166.638	1.03	156.69ns
get_observable	33.70ns	26.4183	1.28	45.33ns
get_subscriber	67.11ns	59.6472	1.13	13.10ns

Linux GCC

Observable construction

Table

Test Name	Current, ns	Prev, ns	Ratio	RxCpp current, ns
Specific observable construction	0.37ns	0.290724	1.27	0.40ns
Dynamic observable construction	21.91ns	16.6927	1.31	27.24ns
Specific observable construction + as_dynamic	22.20ns	16.4564	1.35	27.72ns

Observable lift

Table

Test Name	Current, ns	Prev, ns	Ratio	RxCpp current, ns
Specific observable lift specific observer	34.10ns	25.0271	1.36	423.01ns
Specific observable lift dynamic observer	38.61ns	28.2249	1.37	450.53ns
Dynamic observable lift specific observer	90.80ns	73.3439	1.24	501.63ns
Dynamic observable lift dynamic observer	84.15ns	72.0943	1.17	474.82ns

Observable subscribe

Table

Test Name	Current, ns	Prev, ns	Ratio	RxCpp current, ns
Specific observable subscribe specific observer	28.15ns	21.7785	1.29	407.71ns
Specific observable subscribe dynamic observer	29.63ns	21.5217	1.38	418.81ns
Dynamic observable subscribe specific observer	63.23ns	48.233	1.31	455.08ns
Dynamic observable subscribe dynamic observer	48.03ns	34.9348	1.37	428.53ns

Observable subscribe #2

Table

Test Name	Current, ns	Prev, ns	Ratio	RxCpp current, ns
Specific observable subscribe lambda	27.28ns	22.3665	1.22	384.72ns
Dynamic observable subscribe lambda	69.87ns	55.2249	1.27	504.23ns
Specific observable subscribe lambda without subscription	28.12ns	21.1155	1.33	405.72ns
Dynamic observable subscribe lambda without subscription	63.30ns	42.4452	1.49	489.80ns
Specific observable subscribe specific subscriber	4.26ns	4.72288	0.90	341.05ns
Dynamic observable subscribe specific subscriber	33.39ns	26.4854	1.26	397.48ns
Specific observable subscribe dynamic observer	4.05ns	5.64997	0.72	346.98ns
Dynamic observable subscribe dynamic observer	18.01ns	17.4872	1.03	371.27ns

Observer construction

Table

Test Name	Current, ns	Prev, ns	Ratio	RxCpp current, ns
Specific observer construction	0.40ns	0.315593	1.27	0.40ns
Dynamic observer construction	21.37ns	16.1912	1.32	24.76ns
Specific observer construction + as_dynamic	23.19ns	19.6127	1.18	24.45ns

OnNext

Table

Test Name	Current, ns	Prev, ns	Ratio	RxCpp current, ns
Specific observer OnNext	0.40ns	0.343209	1.16	0.40ns
Dynamic observer OnNext	2.01ns	1.77309	1.14	2.09ns

Operators

Table

Test Name	Current, ns	Prev, ns	Ratio	RxCpp current, ns
map construction from observable via dot + subscribe	17.80ns	15.9456	1.12	426.87ns

Subscriber construction

Table

Test Name	Current, ns	Prev, ns	Ratio	RxCpp current, ns
Make subsriber	25.60ns	21.1624	1.21	69.76ns
Make copy of subscriber	5.11ns	4.1921	1.22	5.40ns
Transform subsriber to dynamic	26.95ns	18.8269	1.43	33.53ns

Subscription

Table

Test Name	Current, ns	Prev, ns	Ratio	RxCpp current, ns
composite_subscription create	25.70ns	19.2295	1.34	65.10ns
composite_subscription add	25.99ns	23.9197	1.09	21.10ns
composite_subscription unsubscribe	9.87ns	6.40399	1.54	12.06ns

foundamental sources

Table

Test Name	Current, ns	Prev, ns	Ratio	RxCpp current, ns
empty	4.15ns	3.51019	1.18	55.70ns
error	43.83ns	35.8246	1.22	98.87ns
never	4.27ns	3.85525	1.11	338.90ns

from

Table

Test Name	Current, ns	Prev, ns	Ratio	RxCpp current, ns
from vector with int	26.99ns	21.19	1.27	84.11ns

just

Table

Test Name	Current, ns	Prev, ns	Ratio	RxCpp current, ns
just send int	4.35ns	3.44693	1.26	61.52ns
just send variadic	4.84ns	4.33843	1.12	56.67ns

merge

Table

Test Name	Current, ns	Prev, ns	Ratio	RxCpp current, ns
merge	4.72ns	3.64721	1.29	179.63ns
merge_with	50.98ns	40.4423	1.26	437.81ns

publish_subject callbacks

Table

Test Name	Current, ns	Prev, ns	Ratio	RxCpp current, ns
on_next	19.79ns	17.3369	1.14	13.91ns
on_error	1.62ns	0.719758	2.25	20.18ns
on_completed	1.60ns	0.660963	2.42	1.60ns

publish_subject routines

Table

Test Name	Current, ns	Prev, ns	Ratio	RxCpp current, ns
construct	143.64ns	141.808	1.01	204.55ns
get_observable	6.95ns	6.00079	1.16	55.09ns
get_subscriber	13.85ns	12.6597	1.09	27.29ns

Windows MSVC

Observable construction

Table

Test Name	Current, ns	Prev, ns	Ratio	RxCpp current, ns
Specific observable construction	1.51ns	1.51043	1.00	0.67ns
Dynamic observable construction	81.62ns	82.0581	0.99	132.86ns
Specific observable construction + as_dynamic	81.47ns	82.071	0.99	124.06ns

Observable lift

Table

Test Name	Current, ns	Prev, ns	Ratio	RxCpp current, ns
Specific observable lift specific observer	155.44ns	139.667	1.11	1215.64ns
Specific observable lift dynamic observer	168.13ns	168.833	1.00	1270.71ns
Dynamic observable lift specific observer	267.45ns	267.032	1.00	1395.21ns
Dynamic observable lift dynamic observer	221.01ns	221.522	1.00	1313.30ns

Observable subscribe

Table

Test Name	Current, ns	Prev, ns	Ratio	RxCpp current, ns
Specific observable subscribe specific observer	104.32ns	105.857	0.99	1174.77ns
Specific observable subscribe dynamic observer	120.04ns	118.962	1.01	1199.23ns
Dynamic observable subscribe specific observer	218.56ns	221.095	0.99	1361.42ns
Dynamic observable subscribe dynamic observer	164.39ns	166.053	0.99	1247.62ns

Observable subscribe #2

Table

Test Name	Current, ns	Prev, ns	Ratio	RxCpp current, ns
Specific observable subscribe lambda	104.68ns	106.667	0.98	1173.91ns
Dynamic observable subscribe lambda	217.91ns	217.906	1.00	1360.21ns
Specific observable subscribe lambda without subscription	104.76ns	106.569	0.98	1166.61ns
Dynamic observable subscribe lambda without subscription	217.92ns	220.922	0.99	1359.80ns
Specific observable subscribe specific subscriber	16.81ns	16.7389	1.00	843.67ns
Dynamic observable subscribe specific subscriber	131.60ns	142.41	0.92	1036.20ns
Specific observable subscribe dynamic observer	16.85ns	16.8803	1.00	888.67ns
Dynamic observable subscribe dynamic observer	64.61ns	64.5318	1.00	919.96ns

Observer construction

Table

Test Name	Current, ns	Prev, ns	Ratio	RxCpp current, ns
Specific observer construction	0.69ns	0.670544	1.03	1.51ns
Dynamic observer construction	81.53ns	82.899	0.98	115.27ns
Specific observer construction + as_dynamic	81.64ns	81.9	1.00	114.65ns

OnNext

Table

Test Name	Current, ns	Prev, ns	Ratio	RxCpp current, ns
Specific observer OnNext	0.67ns	0.670178	1.00	0.67ns
Dynamic observer OnNext	2.02ns	2.01414	1.00	2.02ns

Operators

Table

Test Name	Current, ns	Prev, ns	Ratio	RxCpp current, ns
map construction from observable via dot + subscribe	76.70ns	77.3161	0.99	990.54ns

Subscriber construction

Table

Test Name	Current, ns	Prev, ns	Ratio	RxCpp current, ns
Make subsriber	90.42ns	88.6807	1.02	348.00ns
Make copy of subscriber	16.73ns	16.7821	1.00	31.47ns
Transform subsriber to dynamic	110.45ns	98.2171	1.12	153.01ns

Subscription

Table

Test Name	Current, ns	Prev, ns	Ratio	RxCpp current, ns
composite_subscription create	87.06ns	88.6341	0.98	341.71ns
composite_subscription add	65.52ns	65.3571	1.00	64.30ns
composite_subscription unsubscribe	8.40ns	8.5095	0.99	23.27ns

foundamental sources

Table

Test Name	Current, ns	Prev, ns	Ratio	RxCpp current, ns
empty	16.80ns	17.9346	0.94	192.22ns
error	65.42ns	47.1889	1.39	220.21ns
never	16.74ns	16.7364	1.00	843.81ns

from

Table

Test Name	Current, ns	Prev, ns	Ratio	RxCpp current, ns
from vector with int	83.31ns	83.7558	0.99	264.35ns

just

Table

Test Name	Current, ns	Prev, ns	Ratio	RxCpp current, ns
just send int	19.99ns	19.9077	1.00	193.29ns
just send variadic	20.70ns	20.6969	1.00	192.62ns

merge

Table

Test Name	Current, ns	Prev, ns	Ratio	RxCpp current, ns
merge	35.04ns	34.9653	1.00	670.84ns
merge_with	299.43ns	299.926	1.00	1421.65ns

publish_subject callbacks

Table

Test Name	Current, ns	Prev, ns	Ratio	RxCpp current, ns
on_next	20.27ns	20.1758	1.00	32.54ns
on_error	2.38ns	2.37413	1.00	17.44ns
on_completed	2.38ns	2.37917	1.00	1.36ns

publish_subject routines

Table

Test Name	Current, ns	Prev, ns	Ratio	RxCpp current, ns
construct	301.95ns	290.349	1.04	593.94ns
get_observable	25.91ns	25.7915	1.00	159.80ns
get_subscriber	50.24ns	50.3208	1.00	93.48ns