Fix a lot of minor issues and IDE improvements

[AlexInLog]

No description provided.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
4 Code Smells

0.0% Coverage
0.0% Duplication

[github-actions]

Linux CLANG

Observable construction

Table

Test Name	Current, ns	Prev, ns	Ratio	RxCpp current, ns
Specific observable construction	0.40ns	0.402129	1.00	0.41ns
Dynamic observable construction	28.64ns	31.6128	0.91	25.33ns
Specific observable construction + as_dynamic	28.68ns	31.4229	0.91	25.33ns

Observable lift

Table

Test Name	Current, ns	Prev, ns	Ratio	RxCpp current, ns
Specific observable lift specific observer	77.96ns	78.1921	1.00	286.96ns
Specific observable lift dynamic observer	105.44ns	105.47	1.00	303.30ns
Dynamic observable lift specific observer	160.43ns	160.372	1.00	338.72ns
Dynamic observable lift dynamic observer	176.65ns	183.882	0.96	322.49ns

Observable subscribe

Table

Test Name	Current, ns	Prev, ns	Ratio	RxCpp current, ns
Specific observable subscribe specific observer	48.74ns	48.7346	1.00	286.87ns
Specific observable subscribe dynamic observer	61.85ns	61.2044	1.01	297.03ns
Dynamic observable subscribe specific observer	111.41ns	111.571	1.00	333.24ns
Dynamic observable subscribe dynamic observer	115.42ns	114.364	1.01	314.19ns

Observable subscribe #2

Table

Test Name	Current, ns	Prev, ns	Ratio	RxCpp current, ns
Specific observable subscribe lambda	48.85ns	48.6401	1.00	292.57ns
Dynamic observable subscribe lambda	110.71ns	111.517	0.99	333.25ns
Specific observable subscribe lambda without subscription	48.98ns	48.7596	1.00	283.05ns
Dynamic observable subscribe lambda without subscription	110.65ns	111.494	0.99	333.83ns
Specific observable subscribe specific subscriber	16.07ns	16.5852	0.97	218.79ns
Dynamic observable subscribe specific subscriber	77.80ns	77.9513	1.00	266.94ns
Specific observable subscribe dynamic observer	16.05ns	16.1177	1.00	235.74ns
Dynamic observable subscribe dynamic observer	67.95ns	68.2639	1.00	257.48ns

Observer construction

Table

Test Name	Current, ns	Prev, ns	Ratio	RxCpp current, ns
Specific observer construction	0.80ns	0.401622	2.00	0.40ns
Dynamic observer construction	28.93ns	31.5734	0.92	19.70ns
Specific observer construction + as_dynamic	28.51ns	31.7017	0.90	19.71ns

OnNext

Table

Test Name	Current, ns	Prev, ns	Ratio	RxCpp current, ns
Specific observer OnNext	0.44ns	0.80363	0.55	0.44ns
Dynamic observer OnNext	1.63ns	1.6075	1.01	1.61ns

Operators

Table

Test Name	Current, ns	Prev, ns	Ratio	RxCpp current, ns
map construction from observable via dot + subscribe	75.79ns	75.9032	1.00	237.90ns

Subscriber construction

Table

Test Name	Current, ns	Prev, ns	Ratio	RxCpp current, ns
Make subsriber	32.82ns	33.0655	0.99	66.61ns
Make copy of subscriber	18.89ns	18.8453	1.00	6.52ns
Transform subsriber to dynamic	47.15ns	46.972	1.00	24.75ns

Subscription

Table

Test Name	Current, ns	Prev, ns	Ratio	RxCpp current, ns
composite_subscription create	33.44ns	32.8748	1.02	51.82ns
composite_subscription add	48.46ns	48.5249	1.00	20.96ns
composite_subscription unsubscribe	8.04ns	8.04103	1.00	13.66ns

foundamental sources

Table

Test Name	Current, ns	Prev, ns	Ratio	RxCpp current, ns
empty	16.06ns	16.1038	1.00	31.44ns
error	48.70ns	48.2892	1.01	73.95ns
never	16.09ns	16.0821	1.00	228.41ns

from

Table

Test Name	Current, ns	Prev, ns	Ratio	RxCpp current, ns
from vector with int	26.29ns	25.393	1.04	57.22ns

just

Table

Test Name	Current, ns	Prev, ns	Ratio	RxCpp current, ns
just send int	16.08ns	16.0809	1.00	31.53ns
just send variadic	18.93ns	18.8978	1.00	39.20ns

merge

Table

Test Name	Current, ns	Prev, ns	Ratio	RxCpp current, ns
merge	16.78ns	16.7873	1.00	126.06ns
merge_with	76.77ns	77.0271	1.00	292.41ns

publish_subject callbacks

Table

Test Name	Current, ns	Prev, ns	Ratio	RxCpp current, ns
on_next	29.47ns	29.472	1.00	8.85ns
on_error	2.02ns	2.02032	1.00	19.01ns
on_completed	1.67ns	1.67146	1.00	0.80ns

publish_subject routines

Table

Test Name	Current, ns	Prev, ns	Ratio	RxCpp current, ns
construct	172.79ns	165.0	1.05	151.27ns
get_observable	33.76ns	33.7485	1.00	45.12ns
get_subscriber	67.12ns	67.4837	0.99	13.05ns

Linux GCC

Observable construction

Table

Test Name	Current, ns	Prev, ns	Ratio	RxCpp current, ns
Specific observable construction	0.40ns	0.402697	1.00	0.40ns
Dynamic observable construction	17.70ns	17.361	1.02	21.60ns
Specific observable construction + as_dynamic	17.29ns	17.297	1.00	22.00ns

Observable lift

Table

Test Name	Current, ns	Prev, ns	Ratio	RxCpp current, ns
Specific observable lift specific observer	25.37ns	25.6662	0.99	344.36ns
Specific observable lift dynamic observer	28.44ns	27.89	1.02	352.20ns
Dynamic observable lift specific observer	76.75ns	78.5622	0.98	412.86ns
Dynamic observable lift dynamic observer	71.20ns	72.7333	0.98	404.26ns

Observable subscribe

Table

Test Name	Current, ns	Prev, ns	Ratio	RxCpp current, ns
Specific observable subscribe specific observer	20.30ns	20.5658	0.99	327.53ns
Specific observable subscribe dynamic observer	21.73ns	21.2948	1.02	342.05ns
Dynamic observable subscribe specific observer	50.41ns	50.4993	1.00	382.63ns
Dynamic observable subscribe dynamic observer	37.23ns	37.7705	0.99	361.29ns

Observable subscribe #2

Table

Test Name	Current, ns	Prev, ns	Ratio	RxCpp current, ns
Specific observable subscribe lambda	20.80ns	20.4923	1.01	322.77ns
Dynamic observable subscribe lambda	60.11ns	58.2856	1.03	404.36ns
Specific observable subscribe lambda without subscription	20.46ns	20.2935	1.01	317.81ns
Dynamic observable subscribe lambda without subscription	49.10ns	49.7302	0.99	436.94ns
Specific observable subscribe specific subscriber	6.01ns	6.1035	0.98	279.25ns
Dynamic observable subscribe specific subscriber	28.84ns	29.5093	0.98	323.69ns
Specific observable subscribe dynamic observer	6.02ns	6.02563	1.00	284.00ns
Dynamic observable subscribe dynamic observer	17.07ns	17.3275	0.99	302.47ns

Observer construction

Table

Test Name	Current, ns	Prev, ns	Ratio	RxCpp current, ns
Specific observer construction	0.43ns	0.426858	1.00	0.40ns
Dynamic observer construction	17.30ns	17.434	0.99	18.53ns
Specific observer construction + as_dynamic	17.71ns	17.72	1.00	19.47ns

OnNext

Table

Test Name	Current, ns	Prev, ns	Ratio	RxCpp current, ns
Specific observer OnNext	0.43ns	0.4314	0.99	0.44ns
Dynamic observer OnNext	2.01ns	1.61244	1.25	1.61ns

Operators

Table

Test Name	Current, ns	Prev, ns	Ratio	RxCpp current, ns
map construction from observable via dot + subscribe	24.54ns	24.5579	1.00	478.90ns

Subscriber construction

Table

Test Name	Current, ns	Prev, ns	Ratio	RxCpp current, ns
Make subsriber	19.49ns	19.6433	0.99	53.97ns
Make copy of subscriber	6.05ns	6.06831	1.00	5.88ns
Transform subsriber to dynamic	19.47ns	19.9013	0.98	27.40ns

Subscription

Table

Test Name	Current, ns	Prev, ns	Ratio	RxCpp current, ns
composite_subscription create	19.44ns	19.3077	1.01	50.95ns
composite_subscription add	26.99ns	27.106	1.00	14.93ns
composite_subscription unsubscribe	8.04ns	8.04459	1.00	10.89ns

foundamental sources

Table

Test Name	Current, ns	Prev, ns	Ratio	RxCpp current, ns
empty	5.94ns	5.97763	0.99	46.18ns
error	37.82ns	37.8097	1.00	84.08ns
never	5.95ns	5.95793	1.00	299.84ns

from

Table

Test Name	Current, ns	Prev, ns	Ratio	RxCpp current, ns
from vector with int	19.29ns	20.1122	0.96	60.32ns

just

Table

Test Name	Current, ns	Prev, ns	Ratio	RxCpp current, ns
just send int	5.94ns	5.94192	1.00	48.74ns
just send variadic	5.96ns	5.82321	1.02	46.23ns

merge

Table

Test Name	Current, ns	Prev, ns	Ratio	RxCpp current, ns
merge	6.01ns	6.09455	0.99	132.07ns
merge_with	40.72ns	40.9811	0.99	335.85ns

publish_subject callbacks

Table

Test Name	Current, ns	Prev, ns	Ratio	RxCpp current, ns
on_next	19.71ns	19.7493	1.00	10.85ns
on_error	0.81ns	0.806433	1.00	16.13ns
on_completed	1.21ns	1.20964	1.00	0.81ns

publish_subject routines

Table

Test Name	Current, ns	Prev, ns	Ratio	RxCpp current, ns
construct	118.95ns	119.475	1.00	147.97ns
get_observable	5.68ns	5.62974	1.01	43.00ns
get_subscriber	16.49ns	17.6266	0.94	23.07ns

Windows MSVC

Observable construction

Table

Test Name	Current, ns	Prev, ns	Ratio	RxCpp current, ns
Specific observable construction	1.51ns	1.81258	0.83	0.67ns
Dynamic observable construction	81.66ns	123.453	0.66	128.58ns
Specific observable construction + as_dynamic	81.71ns	98.5116	0.83	128.35ns

Observable lift

Table

Test Name	Current, ns	Prev, ns	Ratio	RxCpp current, ns
Specific observable lift specific observer	137.14ns	167.851	0.82	1209.00ns
Specific observable lift dynamic observer	167.92ns	203.427	0.83	1251.24ns
Dynamic observable lift specific observer	267.78ns	320.759	0.83	1398.95ns
Dynamic observable lift dynamic observer	223.54ns	286.927	0.78	1306.45ns

Observable subscribe

Table

Test Name	Current, ns	Prev, ns	Ratio	RxCpp current, ns
Specific observable subscribe specific observer	104.25ns	127.24	0.82	1167.82ns
Specific observable subscribe dynamic observer	118.46ns	255.71	0.46	1208.05ns
Dynamic observable subscribe specific observer	217.09ns	291.624	0.74	1358.80ns
Dynamic observable subscribe dynamic observer	163.06ns	196.872	0.83	1233.86ns

Observable subscribe #2

Table

Test Name	Current, ns	Prev, ns	Ratio	RxCpp current, ns
Specific observable subscribe lambda	104.77ns	128.087	0.82	1168.32ns
Dynamic observable subscribe lambda	217.75ns	261.797	0.83	1346.20ns
Specific observable subscribe lambda without subscription	104.55ns	127.451	0.82	1173.09ns
Dynamic observable subscribe lambda without subscription	217.39ns	263.351	0.83	1352.21ns
Specific observable subscribe specific subscriber	16.76ns	20.2757	0.83	841.77ns
Dynamic observable subscribe specific subscriber	131.27ns	163.332	0.80	1020.68ns
Specific observable subscribe dynamic observer	16.78ns	20.5387	0.82	879.07ns
Dynamic observable subscribe dynamic observer	64.37ns	77.7103	0.83	910.14ns

Observer construction

Table

Test Name	Current, ns	Prev, ns	Ratio	RxCpp current, ns
Specific observer construction	0.67ns	0.806604	0.84	1.51ns
Dynamic observer construction	81.82ns	98.0584	0.83	115.67ns
Specific observer construction + as_dynamic	82.59ns	98.1158	0.84	115.63ns

OnNext

Table

Test Name	Current, ns	Prev, ns	Ratio	RxCpp current, ns
Specific observer OnNext	0.67ns	0.805395	0.84	0.67ns
Dynamic observer OnNext	1.68ns	2.41761	0.70	2.02ns

Operators

Table

Test Name	Current, ns	Prev, ns	Ratio	RxCpp current, ns
map construction from observable via dot + subscribe	86.79ns	92.1587	0.94	992.00ns

Subscriber construction

Table

Test Name	Current, ns	Prev, ns	Ratio	RxCpp current, ns
Make subsriber	87.28ns	107.163	0.81	347.30ns
Make copy of subscriber	16.75ns	20.122	0.83	31.47ns
Transform subsriber to dynamic	96.76ns	116.688	0.83	153.74ns

Subscription

Table

Test Name	Current, ns	Prev, ns	Ratio	RxCpp current, ns
composite_subscription create	86.66ns	106.54	0.81	343.43ns
composite_subscription add	64.94ns	77.4545	0.84	63.86ns
composite_subscription unsubscribe	8.39ns	10.0646	0.83	23.27ns

foundamental sources

Table

Test Name	Current, ns	Prev, ns	Ratio	RxCpp current, ns
empty	16.83ns	20.2421	0.83	191.10ns
error	47.09ns	59.1401	0.80	206.66ns
never	16.76ns	20.1775	0.83	840.45ns

from

Table

Test Name	Current, ns	Prev, ns	Ratio	RxCpp current, ns
from vector with int	84.34ns	100.227	0.84	264.11ns

just

Table

Test Name	Current, ns	Prev, ns	Ratio	RxCpp current, ns
just send int	20.26ns	23.7958	0.85	191.55ns
just send variadic	20.87ns	25.0504	0.83	194.19ns

merge

Table

Test Name	Current, ns	Prev, ns	Ratio	RxCpp current, ns
merge	34.80ns	42.0445	0.83	684.22ns
merge_with	294.33ns	384.527	0.77	1420.12ns

publish_subject callbacks

Table

Test Name	Current, ns	Prev, ns	Ratio	RxCpp current, ns
on_next	20.11ns	24.6488	0.82	32.55ns
on_error	3.34ns	3.02742	1.10	18.09ns
on_completed	2.53ns	3.14696	0.80	1.36ns

publish_subject routines

Table

Test Name	Current, ns	Prev, ns	Ratio	RxCpp current, ns
construct	297.66ns	349.733	0.85	604.82ns
get_observable	28.24ns	31.0273	0.91	158.16ns
get_subscriber	50.39ns	60.75	0.83	92.22ns