fix(hyprland/workspaces): respect enable-bar-scroll config option - #5232
Open
brian-brow wants to merge 1 commit into
Open
fix(hyprland/workspaces): respect enable-bar-scroll config option#5232brian-brow wants to merge 1 commit into
brian-brow wants to merge 1 commit into
Conversation
Removed hasScrollConfig boolean variable in Workspaces init function. It was Or'd with barScroll boolean variable and overriding it when enable-bar-scroll is declared false in waybar config. Setting any scroll up or down events caused enable-bar-scroll to be overwritten. Tested on Arch/Hyprland, removing hasScrollConfig and the or condition restored expected behavior. Fixes Alexays#5229
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removed
hasScrollConfigboolean variable in Workspaces init function. It was OR'd withbarScroll()and overriding when enable-bar-scroll is declared false in waybar config. Setting any scroll up or down events caused enable-bar-scroll to be ignored.Tested on Arch/Hyprland, removing
hasScrollConfigand the or condition restored expected behavior.Related issues
Closes #5229
Checklist
clang-formatninja -C build)man/)