Skip to content

Master - #3

Merged
hakeemRash merged 2 commits into
mainfrom
master
Jul 7, 2026
Merged

Master#3
hakeemRash merged 2 commits into
mainfrom
master

Conversation

@hakeemRash

@hakeemRash hakeemRash commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • New Features

    • Added a new CI workflow that runs on pushes and pull requests to main, with concurrency control and read-only repository permissions.
    • Added automated checks for multiple PHP versions and multi-platform Zig builds.
  • Tests

    • Expanded test coverage for HTTP requests and responses, dependency resolution, security identities, verdict handling, and exception behavior.
    • Added coverage for status codes, JSON output, immutability, error payloads, and dependency ordering.

@hakeemRash
hakeemRash merged commit 86cf270 into main Jul 7, 2026
0 of 8 checks passed
@coderabbitai

coderabbitai Bot commented Jul 7, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: d080cff3-6c1f-44b0-8a6a-d34f92d36fc2

📥 Commits

Reviewing files that changed from the base of the PR and between a7df04b and 7fd6373.

📒 Files selected for processing (7)
  • .github/workflows/ci.yml
  • tests/Unit/Kernel/Exceptions/FrameworkExceptionTest.php
  • tests/Unit/Kernel/Http/RequestTest.php
  • tests/Unit/Kernel/Http/ResponseTest.php
  • tests/Unit/Kernel/Loading/DependencyGraphCalculatorTest.php
  • tests/Unit/Kernel/Security/IdentityTest.php
  • tests/Unit/Kernel/Security/SecurityVerdictTest.php

📝 Walkthrough

Walkthrough

This PR adds a GitHub Actions CI workflow that runs a PHP test matrix (PHPUnit) and a Zig build matrix, plus new PHPUnit unit test suites for Kernel exceptions, HTTP Request/Response, dependency graph resolution, and security Identity/SecurityVerdict classes. No production code changes.

Changes

CI Workflow

Layer / File(s) Summary
Workflow triggers and PHP/Zig jobs
.github/workflows/ci.yml
Adds a CI workflow triggered on pushes/PRs to main with read-only permissions and concurrency cancellation; defines a PHP test matrix job (8.2–8.4) running PHPUnit, and a Zig build matrix job compiling a release launcher for multiple targets.

Estimated code review effort: 2 (Simple) | ~10 minutes

Kernel Unit Test Suites

Layer / File(s) Summary
Framework exception tests
tests/Unit/Kernel/Exceptions/FrameworkExceptionTest.php
Adds tests for exception inheritance, layer/context propagation, previous-throwable preservation, and ValidationException's errors structure.
HTTP Request tests
tests/Unit/Kernel/Http/RequestTest.php
Adds tests for method/path normalization, input merging, typed accessor casting, and immutability of withAttribute/withIdentity.
HTTP Response tests
tests/Unit/Kernel/Http/ResponseTest.php
Adds tests for json/created/noContent factories, error envelopes via data provider, unprocessable field errors, and redirect defaults.
Dependency graph calculator tests
tests/Unit/Kernel/Loading/DependencyGraphCalculatorTest.php
Adds tests for resolution ordering, dependency de-duplication, domain seeding, circular/missing-service exceptions, and manifest entry lookup.
Security Identity and SecurityVerdict tests
tests/Unit/Kernel/Security/IdentityTest.php, tests/Unit/Kernel/Security/SecurityVerdictTest.php
Adds tests for role/permission matching, wildcard permissions, guest/asUser/asAdmin factories, and SecurityVerdict deny/allow behaviors.

Estimated code review effort: 2 (Simple) | ~15 minutes

Estimated code review effort: 2 (Simple) | ~20 minutes

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch master

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

hakeemRash added a commit that referenced this pull request Jul 11, 2026
hakeemRash added a commit that referenced this pull request Jul 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant