fix: fix linting issues in main,benchmark, and generate - #33
Open
AlishChhetri wants to merge 4 commits into
Open
fix: fix linting issues in main,benchmark, and generate#33AlishChhetri wants to merge 4 commits into
AlishChhetri wants to merge 4 commits into
Conversation
AlishChhetri
requested review from
Barker0103,
Jacob-Allebach,
PCain02,
boulais01,
gyamfi01,
rebekahrudd and
simojo
April 29, 2024 02:28
Collaborator
|
This doesn't necessarily fix #32 if there are still lingering linting errors. Would you rather remove the "Fixes #..." from the description or fix all the errors in this PR? Sorry for the matter-of-fact response.. 🥲 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changes made to address the linting issues presented in issue #32
Fixes #32
Type of change
Please delete options that are not relevant.
not work as expected)
How Has This Been Tested?
Please briefly write the names of the added tests to test your functionality.
Ran
poetry run task lintto test this change