Skip to content

[CTP] Add digit reader workflow#12364

Merged
shahor02 merged 1 commit into
AliceO2Group:devfrom
mfasDa:feature-ctpdigitreader
Dec 1, 2023
Merged

[CTP] Add digit reader workflow#12364
shahor02 merged 1 commit into
AliceO2Group:devfrom
mfasDa:feature-ctpdigitreader

Conversation

@mfasDa
Copy link
Copy Markdown
Collaborator

@mfasDa mfasDa commented Nov 30, 2023

Needed for QC at simulation level

@mfasDa mfasDa requested a review from a team as a code owner November 30, 2023 13:22
@mfasDa mfasDa requested a review from shahor02 November 30, 2023 13:23
@mfasDa
Copy link
Copy Markdown
Collaborator Author

mfasDa commented Nov 30, 2023

Needed for QC in MC: In MC QC tasks are not attached to the AOD producer workflow but run sequentially with the file readers as data source. In order for QC tasks to subscribe to CTP digits the corresponding reader needs to be provided.

@lietava Please check!

@mfasDa mfasDa force-pushed the feature-ctpdigitreader branch from 7368c41 to 6011cdf Compare November 30, 2023 13:42
@lietava
Copy link
Copy Markdown
Contributor

lietava commented Nov 30, 2023

@mfasDa well, ok. Although it is more for @shahor02.

#include "DetectorsRaw/HBFUtilsInitializer.h"

using namespace o2::framework;

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add here


void customize(std::vector<o2::framework::CallbacksPolicy>& policies)
{
  o2::raw::HBFUtilsInitializer::addNewTimeSliceCallback(policies);
}

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

std::vector<o2::framework::ConfigParamSpec> options{
{"inputfile", o2::framework::VariantType::String, "ctpdigits.root", {"File with CTP digits"}},
{"disable-mc", o2::framework::VariantType::Bool, false, {"Do not reed MC truth branch"}},
{"configKeyValues", VariantType::String, "", {"Semicolon separated key=value strings"}}};
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add after this

o2::raw::HBFUtilsInitializer::addConfigOption(options);

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Needed for QC at simulation level

In addition fix copyright statement
in CMakeLists.txt
@mfasDa mfasDa force-pushed the feature-ctpdigitreader branch from 6011cdf to 887b022 Compare November 30, 2023 14:43
@mfasDa
Copy link
Copy Markdown
Collaborator Author

mfasDa commented Nov 30, 2023

CI errors unrelated

@shahor02 shahor02 merged commit 2c026d9 into AliceO2Group:dev Dec 1, 2023
@mfasDa mfasDa deleted the feature-ctpdigitreader branch December 1, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants