SIM: Possible fix for -run5 executables for detectorList#13295
SIM: Possible fix for -run5 executables for detectorList#13295f3sch wants to merge 3 commits intoAliceO2Group:devfrom
Conversation
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
|
Do we still need o2-sim-run5 at all? In principle we could just use o2-sim, now that we have detectorlists? (At least, this may be a goal) |
|
If you want I can also remove the executable entirely since they are from what I see anyways just copies with different names and I do not see any usage of |
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
|
Hi @sawenzel, following the recent discussion on the run5 executables I would propose to remove them entirely. |
|
Error while checking build/O2/fullCI for b9cbac9 at 2024-08-24 21:48: Full log here. |
|
Hi @sawenzel, should I close this PR? |
|
@sawenzel since we do not do releases, there is no deprecation policy, so should we keep it just as it is for now? |
|
@f3sch : I took a look. For me, the amount of changes seem substantial and I would not be in favour of merging it at this moment. There may be alternative/shorter ways of influencing the default list (as a function of the executable). |
|
sure, thanks for commenting :) |
Hi @sawenzel, @mconcas noticed that for
o2-sim-serial-run5the default for the dectorList is ALICE2 which makes IMO little sense.This MR would fix this by setting the default to ALICE3 for those run5 executables. I however do not like that I have to extend several function calls to propagate a single boolean. What would you suggest to
fixthis (does it even need fixing?). One other idea would be toclonethe allsim target and add a preprocessor define likeSIM_RUN5. What do you think?