Skip to content

SIM: Possible fix for -run5 executables for detectorList#13295

Closed
f3sch wants to merge 3 commits intoAliceO2Group:devfrom
f3sch:sim/run5list_fix
Closed

SIM: Possible fix for -run5 executables for detectorList#13295
f3sch wants to merge 3 commits intoAliceO2Group:devfrom
f3sch:sim/run5list_fix

Conversation

@f3sch
Copy link
Copy Markdown
Collaborator

@f3sch f3sch commented Jul 12, 2024

Hi @sawenzel, @mconcas noticed that for o2-sim-serial-run5 the default for the dectorList is ALICE2 which makes IMO little sense.
This MR would fix this by setting the default to ALICE3 for those run5 executables. I however do not like that I have to extend several function calls to propagate a single boolean. What would you suggest to fix this (does it even need fixing?). One other idea would be to clone the allsim target and add a preprocessor define like SIM_RUN5. What do you think?

@github-actions
Copy link
Copy Markdown
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass3
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0

@sawenzel
Copy link
Copy Markdown
Collaborator

Do we still need o2-sim-run5 at all? In principle we could just use o2-sim, now that we have detectorlists? (At least, this may be a goal)

@f3sch
Copy link
Copy Markdown
Collaborator Author

f3sch commented Jul 12, 2024

If you want I can also remove the executable entirely since they are from what I see anyways just copies with different names and I do not see any usage of SimConfigData::mIsUpgrade.

f3sch added 3 commits August 1, 2024 09:41
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
@f3sch f3sch force-pushed the sim/run5list_fix branch from d48b1f5 to b9cbac9 Compare August 1, 2024 09:10
@f3sch
Copy link
Copy Markdown
Collaborator Author

f3sch commented Aug 1, 2024

Hi @sawenzel, following the recent discussion on the run5 executables I would propose to remove them entirely.
Also with the second commit, the printing of which list is used is slightly cleared up, e.g., not intermixing them anymore if the SimConfig constructed was called. Let me know if this is okay.

@f3sch f3sch marked this pull request as ready for review August 1, 2024 09:15
@alibuild
Copy link
Copy Markdown
Collaborator

alibuild commented Aug 1, 2024

Error while checking build/O2/fullCI for b9cbac9 at 2024-08-24 21:48:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
/sw/SOURCES/O2/13295-slc8_x86-64/0/Generators/src/GeneratorTParticle.cxx:28:21: error: use '= default' to define a trivial default constructor [modernize-use-equals-default]
++ [[ 0 == 0 ]]
++ exit 1
--

Full log here.

@f3sch
Copy link
Copy Markdown
Collaborator Author

f3sch commented Aug 19, 2024

Hi @sawenzel, should I close this PR?

@f3sch
Copy link
Copy Markdown
Collaborator Author

f3sch commented Aug 26, 2024

@sawenzel since we do not do releases, there is no deprecation policy, so should we keep it just as it is for now?

@sawenzel
Copy link
Copy Markdown
Collaborator

@f3sch : I took a look. For me, the amount of changes seem substantial and I would not be in favour of merging it at this moment. There may be alternative/shorter ways of influencing the default list (as a function of the executable).

@f3sch
Copy link
Copy Markdown
Collaborator Author

f3sch commented Aug 26, 2024

sure, thanks for commenting :)

@f3sch f3sch closed this Aug 26, 2024
@sawenzel
Copy link
Copy Markdown
Collaborator

@mconcas @f3sch : Could you take a look if #13430 would be good step forward?

@f3sch f3sch deleted the sim/run5list_fix branch November 25, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants