Skip to content

o2-sim: Ability to adjust default option values depending on Run5 or not#13430

Merged
sawenzel merged 1 commit intoAliceO2Group:devfrom
sawenzel:swenzel/run5-default-geomlist
Aug 26, 2024
Merged

o2-sim: Ability to adjust default option values depending on Run5 or not#13430
sawenzel merged 1 commit intoAliceO2Group:devfrom
sawenzel:swenzel/run5-default-geomlist

Conversation

@sawenzel
Copy link
Copy Markdown
Collaborator

No description provided.

@github-actions
Copy link
Copy Markdown
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass3
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0

@mconcas
Copy link
Copy Markdown
Collaborator

mconcas commented Aug 26, 2024

This would leave the o2-sim-run5 exe?
Fine to me, in general I'm fine to whatever works :)

@sawenzel
Copy link
Copy Markdown
Collaborator Author

@mconcas : Yes, it is just a minor consistency fix for the run5 executable. The complete deprecation can be done later.

@alibuild
Copy link
Copy Markdown
Collaborator

Error while checking build/O2/fullCI for 4e2c2e4 at 2024-08-26 15:01:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
/sw/SOURCES/O2/13430-slc8_x86-64/0/Generators/src/GeneratorTParticle.cxx:28:21: error: use '= default' to define a trivial default constructor [modernize-use-equals-default]
++ [[ 0 == 0 ]]
++ exit 1
--

Full log here.

@sawenzel sawenzel merged commit a7150e2 into AliceO2Group:dev Aug 26, 2024
@alcaliva alcaliva added the async-2024-pp-apass1 Request porting to async-2024-pp-apass1 label Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

async-2024-pp-apass1 Request porting to async-2024-pp-apass1

Development

Successfully merging this pull request may close these issues.

4 participants