Link against the dynamic library of ZeroMq#146
Merged
Conversation
Member
|
@MohammadAlTurany is actually the issue why libsodium can cause problems if support for it is enabled in ZMQ. ZMQ_LIBRARIES adds both the archive and the dynamic version of the library, which is wrong because the archive one requires all its dependencies (hence libsodium) to be specified. @Barthelemy This is one thing we should take care of in the buckets, actually, just like for the optional DDS dependency. I will continue the discussion on the JIRA issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes compilation issue (Could not find libsodium)