Different workaround for false codechecker error#4955
Merged
Conversation
Contributor
|
Hm. How did I forget that I could just disable check for a line :/ |
Collaborator
Author
|
@Barthelemy : Could you check this compile warning, which currently breaks the CI: @sy-c : The same for readout with this warning: |
Collaborator
Author
|
Errors unrelated to this PR, merging. |
Collaborator
|
@davidrohr there is already a PR in QC for that and I have just merged it. AliceO2Group/QualityControl#556 |
Collaborator
Author
|
@Barthelemy : Thx, can we have a new tag then? Or shall we first test locally whether it works? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@anerokhi : Your workaround turned out to break GPU compilation in some cases, since some types might be only forward-declared in the header, so the implementation of the constructors etc. must be moved to the CXX. I have thus disabled the linter on this line.