Skip to content

Different workaround for false codechecker error#4955

Merged
davidrohr merged 2 commits into
AliceO2Group:devfrom
davidrohr:dev_pull_request
Nov 30, 2020
Merged

Different workaround for false codechecker error#4955
davidrohr merged 2 commits into
AliceO2Group:devfrom
davidrohr:dev_pull_request

Conversation

@davidrohr
Copy link
Copy Markdown
Collaborator

@anerokhi : Your workaround turned out to break GPU compilation in some cases, since some types might be only forward-declared in the header, so the implementation of the constructors etc. must be moved to the CXX. I have thus disabled the linter on this line.

@anerokhi
Copy link
Copy Markdown
Contributor

anerokhi commented Nov 30, 2020

Hm. How did I forget that I could just disable check for a line :/

@davidrohr
Copy link
Copy Markdown
Collaborator Author

@Barthelemy : Could you check this compile warning, which currently breaks the CI:

Modules/TOF/include/TOF/TaskDiagnostics.h:45:7: error: 'o2::quality_control_modules::tof::DiagnosticsCounter' has a field 'o2::quality_control_modules::tof::DiagnosticsCounter::mRDHCounter' whose type uses the anonymous namespace

@sy-c : The same for readout with this warning:

src/ReadoutUtils.cxx:165:29: error: control reaches end of non-void function

@davidrohr
Copy link
Copy Markdown
Collaborator Author

Errors unrelated to this PR, merging.

@davidrohr davidrohr merged commit 703dc34 into AliceO2Group:dev Nov 30, 2020
@Barthelemy
Copy link
Copy Markdown
Collaborator

@davidrohr there is already a PR in QC for that and I have just merged it. AliceO2Group/QualityControl#556

@davidrohr
Copy link
Copy Markdown
Collaborator Author

@Barthelemy : Thx, can we have a new tag then? Or shall we first test locally whether it works?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants