Update to TOF QC#556
Merged
Merged
Conversation
Collaborator
njacazio
commented
Nov 20, 2020
njacazio
commented
- Add json configuration for the whole TOF QC chain
- Extend counter functionalities
- Working in labelless mode
- Skipping empty bins when filling histograms
- Merge Raw Data tasks
- Prefer counters over histograms in RawData task
- Fix compilation warning https://alice.its.cern.ch/jira/browse/QC-487
- Add also more utilities to count entries
- Add orbitID, BCTime, EventCounter histograms - Add counters for hits in view of filtering of noisy channels - Add per channel hit counter
Co-authored-by: Francesca Ercolessi <francesca.ercolessi@cern.ch>
* Update crate number name in post processing * Installing new TOF JSONs
- Add comments - Format
- Rename tof.json to tofdigit.json - Format json files
- Reverted to the header only scheme
Collaborator
Author
|
@Barthelemy @knopers8 we are ready for review. Also, can it be that the CI is stuck? |
Collaborator
|
Barthelemy
approved these changes
Nov 27, 2020
Collaborator
Barthelemy
left a comment
Barthelemy
left a comment
There was a problem hiding this comment.
All good. I don't review the logic of the detectors' code but the guidelines are followed and it is will documented and very readable. Congrats and thank you.
Collaborator
|
FYI the CI failures are followed here: https://alice.its.cern.ch/jira/browse/O2-1858 |
Member
|
Can we merge this? It's one of the things which is breaking the CI. |
Collaborator
|
given the amount of changes, I would not merge it before it passes the tests. Another PR should fix a couple of tests. Let's see |
Collaborator
|
@TimoWilken I have the feeling that the mac checkers are not building |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.