[O2B-1083] Fix a bug in LHC overview pages, now displaying missing dates as '-' instead of the default epoch time#1298
Merged
graduta merged 5 commits intoDec 14, 2023
Conversation
…h time for the lhcFillAdapter
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1298 +/- ##
=======================================
Coverage 45.58% 45.59%
=======================================
Files 699 699
Lines 11090 11092 +2
Branches 2023 2025 +2
=======================================
+ Hits 5055 5057 +2
Misses 6035 6035 ☔ View full report in Codecov by Sentry. |
martinboulais
suggested changes
Dec 13, 2023
martinboulais
approved these changes
Dec 14, 2023
…t-epoch-when-null-bug
graduta
deleted the
SandroBoelsz/O2B-1083/fix-empty-date-to-start-epoch-when-null-bug
branch
December 14, 2023 12:16
CollinPoetoehena
added a commit
that referenced
this pull request
Dec 14, 2023
* [O2B-1077] Keep scroll in popover after re-rendering (#1300) * [O2B-1066]: Added extra check for empty for log environment filter (#1296) * [O2B-1066]: Added extra check for empty value after initialization * [O2B-1083] Fix a bug in LHC overview pages, now displaying missing dates as '-' instead of the default epoch time (#1298) * [1084] add getOrCreate function to UserService (#1294) * feat: add getorcreate function in UserService * test: add tests for get or create user * refactor: create or update user service * test: update tests with new create or update service * fix: file paths create or update user * refactor: delete unused old usecase for users * fix: update user test broken * refactor: add update chech + code improvement * test: add test case for not updating user * refactor: implement comments on PR * refactor: move one time used code in create user --------- Co-authored-by: Martin Boulais <31805063+martinboulais@users.noreply.github.com> Co-authored-by: mennokonijn <99171568+mennokonijn@users.noreply.github.com> Co-authored-by: SandroBoelsz <97670955+SandroBoelsz@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have a JIRA ticket
Notable changes for users:
Notable changes for developers:
Changes made to the database: