Collinhva/o2 b 1108/environment filter on current status#1343
Merged
CollinPoetoehena merged 11 commits intoJan 17, 2024
Conversation
* add migration
* add references
* add model associations
* add jsonRequest method
* add abstract synchronizer
* cleanup
* cleanup
* cleanup
* cleanup
* cleanup
* simplify
* cleanup
* cleanup
* add monalisa service
* docs annotation
* refactor
* change main method to return void instead of boolean
* db action
* handle field mappings
* remove abstract class
* single concrete class
* add variables
* use env vars
* linter
* refactor
* docs refactor
* typo
* refactor
* refactor
* fixes
* refactored
* not then chain
* refactor{
* types
* rename
* use seuqlize to fetch last runs
* add type, use URL class
* remove file read
* docs
* add synchronizer factory
* add docs
* cleanup
* no await
* refactor
* typdef
* refactor context
* rename
* docs
* docs
* rename
* working
* rename
* rename
* add test for getting data passes
* add test for getting data passes
* sync test
* add test for data pass sync
* amend data
* add details fetching
* add env
* fetching data passes and details
* rename
* add tests
* rename
* reduce test data size
* docs
* refactor
* typo
* typo
* docs
* rename
* docs
* cleanup
* remove dead code
* add service
* cleanup
* add filtering by periods
* add data passes seeders
* rename
* add data passes service tests
* test
* revoke unfound changes
* add controllers
* rename
* refactor
* refactor
* refactor
* no dependency
* refactor
* refactor
* refactor:
* reaname'
* rename
* cleanup
* docs
* reaname
* refactor
* add router
* restore
* amend test
* expose api
* add test
* add tests
* amend
* docs
* amend test
* amend
* rename
* remove clause 'other' (#1335) * test: add test for filtering in API * [O2B-1104] added explicit ordering by the created_at date to solve test failing sometimes (#1338) * test: add more tests for environment API --------- Co-authored-by: xsalonx <65893715+xsalonx@users.noreply.github.com> Co-authored-by: SandroBoelsz <97670955+SandroBoelsz@users.noreply.github.com>
CollinPoetoehena
requested review from
graduta and
martinboulais
as code owners
January 17, 2024 12:28
…nto collinhva/O2B-1108/Environment-filter-on-current-status
CollinPoetoehena
merged commit Jan 17, 2024
19d6c4f
into
collinhva/O2B-1109/Environment-filter-status-history
CollinPoetoehena
added a commit
that referenced
this pull request
Jan 22, 2024
* feat: add like filtering for ids * feat: add exact filter for environment ids * fix: fix lint problems * refactor: implement comment on PR * test: add tests for feature * temp * docs: add TODO * test: add test for filtering in API * refactor: currentStatus without OR and AND, just OR * docs: add TODO * test: add more tests for environment API * feat: add design of filter * feat: current status filter * Collinhva/o2 b 1107/filter on environment (#1341) * remove clause 'other' (#1335) * test: add test for filtering in API * [O2B-1104] added explicit ordering by the created_at date to solve test failing sometimes (#1338) * test: add more tests for environment API --------- Co-authored-by: xsalonx <65893715+xsalonx@users.noreply.github.com> Co-authored-by: SandroBoelsz <97670955+SandroBoelsz@users.noreply.github.com> * test: add tests for filter feature * Collinhva/o2 b 1108/environment filter on current status (#1343) * temp * docs: add TODO * refactor: currentStatus without OR and AND, just OR * docs: add TODO * [O2B-1111] Implement data passes API (#1325) * add migration * add references * add model associations * add jsonRequest method * add abstract synchronizer * cleanup * cleanup * cleanup * cleanup * cleanup * simplify * cleanup * cleanup * add monalisa service * docs annotation * refactor * change main method to return void instead of boolean * db action * handle field mappings * remove abstract class * single concrete class * add variables * use env vars * linter * refactor * docs refactor * typo * refactor * refactor * fixes * refactored * not then chain * refactor{ * types * rename * use seuqlize to fetch last runs * add type, use URL class * remove file read * docs * add synchronizer factory * add docs * cleanup * no await * refactor * typdef * refactor context * rename * docs * docs * rename * working * rename * rename * add test for getting data passes * add test for getting data passes * sync test * add test for data pass sync * amend data * add details fetching * add env * fetching data passes and details * rename * add tests * rename * reduce test data size * docs * refactor * typo * typo * docs * rename * docs * cleanup * remove dead code * add service * cleanup * add filtering by periods * add data passes seeders * rename * add data passes service tests * test * revoke unfound changes * add controllers * rename * refactor * refactor * refactor * no dependency * refactor * refactor * refactor: * reaname' * rename * cleanup * docs * reaname * refactor * add router * restore * amend test * expose api * add test * add tests * amend * docs * amend test * amend * rename * [O2B-1087] Rollback usage of RemoteData.map not already available (#1339) * feat: current status filter * Collinhva/o2 b 1107/filter on environment (#1341) * remove clause 'other' (#1335) * test: add test for filtering in API * [O2B-1104] added explicit ordering by the created_at date to solve test failing sometimes (#1338) * test: add more tests for environment API --------- Co-authored-by: xsalonx <65893715+xsalonx@users.noreply.github.com> Co-authored-by: SandroBoelsz <97670955+SandroBoelsz@users.noreply.github.com> * test: add tests for filter feature --------- Co-authored-by: xsalonx <65893715+xsalonx@users.noreply.github.com> Co-authored-by: Martin Boulais <31805063+martinboulais@users.noreply.github.com> Co-authored-by: SandroBoelsz <97670955+SandroBoelsz@users.noreply.github.com> * fix: fix merge conflicts * feat: add status history filter * test: add tests for new filter * refactor: implement new status acronym legend * temp, not yet working, but closer * refactor: use sequelize query for status filter * fix: sequelize query not working * cleanup * refactor: restore unnecessary enters * Revert "Merge branch 'collinhva/O2B-1109/Environment-filter-status-history' into collinhva/O2B-1108/Environment-filter-on-current-status" This reverts commit bd8e16d, reversing changes made to 440f066. * test: add requested extra tests for PR * test: name improvements * refactor: remove unused property --------- Co-authored-by: xsalonx <65893715+xsalonx@users.noreply.github.com> Co-authored-by: SandroBoelsz <97670955+SandroBoelsz@users.noreply.github.com> Co-authored-by: Martin Boulais <31805063+martinboulais@users.noreply.github.com>
CollinPoetoehena
added a commit
that referenced
this pull request
Jan 22, 2024
* feat: add like filtering for ids * feat: add exact filter for environment ids * fix: fix lint problems * refactor: implement comment on PR * test: add tests for feature * test: add test for filtering in API * test: add more tests for environment API * feat: add design of filter * Collinhva/o2 b 1108/environment filter on current status (#1343) * temp * docs: add TODO * refactor: currentStatus without OR and AND, just OR * docs: add TODO * [O2B-1111] Implement data passes API (#1325) * add migration * add references * add model associations * add jsonRequest method * add abstract synchronizer * cleanup * cleanup * cleanup * cleanup * cleanup * simplify * cleanup * cleanup * add monalisa service * docs annotation * refactor * change main method to return void instead of boolean * db action * handle field mappings * remove abstract class * single concrete class * add variables * use env vars * linter * refactor * docs refactor * typo * refactor * refactor * fixes * refactored * not then chain * refactor{ * types * rename * use seuqlize to fetch last runs * add type, use URL class * remove file read * docs * add synchronizer factory * add docs * cleanup * no await * refactor * typdef * refactor context * rename * docs * docs * rename * working * rename * rename * add test for getting data passes * add test for getting data passes * sync test * add test for data pass sync * amend data * add details fetching * add env * fetching data passes and details * rename * add tests * rename * reduce test data size * docs * refactor * typo * typo * docs * rename * docs * cleanup * remove dead code * add service * cleanup * add filtering by periods * add data passes seeders * rename * add data passes service tests * test * revoke unfound changes * add controllers * rename * refactor * refactor * refactor * no dependency * refactor * refactor * refactor: * reaname' * rename * cleanup * docs * reaname * refactor * add router * restore * amend test * expose api * add test * add tests * amend * docs * amend test * amend * rename * [O2B-1087] Rollback usage of RemoteData.map not already available (#1339) * feat: current status filter * Collinhva/o2 b 1107/filter on environment (#1341) * remove clause 'other' (#1335) * test: add test for filtering in API * [O2B-1104] added explicit ordering by the created_at date to solve test failing sometimes (#1338) * test: add more tests for environment API --------- Co-authored-by: xsalonx <65893715+xsalonx@users.noreply.github.com> Co-authored-by: SandroBoelsz <97670955+SandroBoelsz@users.noreply.github.com> * test: add tests for filter feature --------- Co-authored-by: xsalonx <65893715+xsalonx@users.noreply.github.com> Co-authored-by: Martin Boulais <31805063+martinboulais@users.noreply.github.com> Co-authored-by: SandroBoelsz <97670955+SandroBoelsz@users.noreply.github.com> * feat: add status history filter * test: add tests for new filter * refactor: implement new status acronym legend * feat: add environment filter for run numbers * test: add tests for new feature * feat: use sequelize query for run number * Collinhva/o2 b 1108/environment filter on current status (#1351) * temp * docs: add TODO * refactor: currentStatus without OR and AND, just OR * docs: add TODO * feat: current status filter * Collinhva/o2 b 1107/filter on environment (#1341) * remove clause 'other' (#1335) * test: add test for filtering in API * [O2B-1104] added explicit ordering by the created_at date to solve test failing sometimes (#1338) * test: add more tests for environment API --------- Co-authored-by: xsalonx <65893715+xsalonx@users.noreply.github.com> Co-authored-by: SandroBoelsz <97670955+SandroBoelsz@users.noreply.github.com> * test: add tests for filter feature * fix: fix merge conflicts * [O2-4106] Fix race condition in running protoc on RHEL8 (#1158) * [O2-4106] Fix race condition in running protoc * Remove commented code * Fix install missing target * Increment version * Copy include files --------- Co-authored-by: Martin Boulais <31805063+martinboulais@users.noreply.github.com> * [O2B-1107] Filter on environment id (#1326) * feat: add like filtering for ids * feat: add exact filter for environment ids * fix: fix lint problems * refactor: implement comment on PR * test: add tests for feature * test: add test for filtering in API * test: add more tests for environment API * [O2B-1125] Use scheduled process manager for synchronisation with MonALISA (#1340) * instnatiate synchronzier * typo * use const instead of class property * [O2B-1020] Bug fix for LHC Fill info disappearing (#1344) * fix: subsequently fetch the new run info after saving run update. * fix: cleaned up code for linter --------- Co-authored-by: Saif Rashed <saifrashed@mbp-van-saif.kpn> * [O2B-1094] Add runs counts to lhc periods view (#1334) * calculate runsCount * add some color * add color * add test * amend test * rename * [O2B-1103] Environment history occurrences histogram (#1328) * [O2B-1103] implemented the environment history occurrences histogram * [O2B-1103] implemented changes requested in the API PR * [O2B-1103] additional fix for the PR changes * [O2B-1103] changed existing status acronyms in accordance to the RMreportW29_2023 * [O2B-1103] added a max displayed bin limit to the environmentHistoryOccurences chart --------- Co-authored-by: Martin Boulais <31805063+martinboulais@users.noreply.github.com> * Release 0.76.0 (#1349) * temp, not yet working, but closer * [O2B-1122] Use generic overview page model in LHC Periods model (#1336) * amend * docs * refactor: use sequelize query for status filter * fix: sequelize query not working * cleanup * refactor: restore unnecessary enters --------- Co-authored-by: xsalonx <65893715+xsalonx@users.noreply.github.com> Co-authored-by: SandroBoelsz <97670955+SandroBoelsz@users.noreply.github.com> Co-authored-by: Adam Wegrzynek <awegrzyn@users.noreply.github.com> Co-authored-by: Martin Boulais <31805063+martinboulais@users.noreply.github.com> Co-authored-by: Saif <38007030+saifrashed@users.noreply.github.com> Co-authored-by: Saif Rashed <saifrashed@mbp-van-saif.kpn> * refactor: use sequelize query instead of js filter * test: add limit tests as requested in previous pr * Revert "Merge branch 'collinhva/O2B-1110/Environment-filter-on-run-number' into collinhva/O2B-1109/Environment-filter-status-history" This reverts commit 3403055, reversing changes made to 784da51. * fix: fix merge conflicts * retest automatic status checks for pr --------- Co-authored-by: CollinHva <70367582+CollinHva@users.noreply.github.com> Co-authored-by: xsalonx <65893715+xsalonx@users.noreply.github.com> Co-authored-by: Martin Boulais <31805063+martinboulais@users.noreply.github.com> Co-authored-by: SandroBoelsz <97670955+SandroBoelsz@users.noreply.github.com> Co-authored-by: Adam Wegrzynek <awegrzyn@users.noreply.github.com> Co-authored-by: Saif <38007030+saifrashed@users.noreply.github.com> Co-authored-by: Saif Rashed <saifrashed@mbp-van-saif.kpn>
CollinPoetoehena
added a commit
that referenced
this pull request
Jan 23, 2024
* feat: add like filtering for ids * feat: add exact filter for environment ids * fix: fix lint problems * refactor: implement comment on PR * test: add tests for feature * test: add test for filtering in API * test: add more tests for environment API * feat: add design of filter * Collinhva/o2 b 1108/environment filter on current status (#1343) * temp * docs: add TODO * refactor: currentStatus without OR and AND, just OR * docs: add TODO * [O2B-1111] Implement data passes API (#1325) * add migration * add references * add model associations * add jsonRequest method * add abstract synchronizer * cleanup * cleanup * cleanup * cleanup * cleanup * simplify * cleanup * cleanup * add monalisa service * docs annotation * refactor * change main method to return void instead of boolean * db action * handle field mappings * remove abstract class * single concrete class * add variables * use env vars * linter * refactor * docs refactor * typo * refactor * refactor * fixes * refactored * not then chain * refactor{ * types * rename * use seuqlize to fetch last runs * add type, use URL class * remove file read * docs * add synchronizer factory * add docs * cleanup * no await * refactor * typdef * refactor context * rename * docs * docs * rename * working * rename * rename * add test for getting data passes * add test for getting data passes * sync test * add test for data pass sync * amend data * add details fetching * add env * fetching data passes and details * rename * add tests * rename * reduce test data size * docs * refactor * typo * typo * docs * rename * docs * cleanup * remove dead code * add service * cleanup * add filtering by periods * add data passes seeders * rename * add data passes service tests * test * revoke unfound changes * add controllers * rename * refactor * refactor * refactor * no dependency * refactor * refactor * refactor: * reaname' * rename * cleanup * docs * reaname * refactor * add router * restore * amend test * expose api * add test * add tests * amend * docs * amend test * amend * rename * [O2B-1087] Rollback usage of RemoteData.map not already available (#1339) * feat: current status filter * Collinhva/o2 b 1107/filter on environment (#1341) * remove clause 'other' (#1335) * test: add test for filtering in API * [O2B-1104] added explicit ordering by the created_at date to solve test failing sometimes (#1338) * test: add more tests for environment API --------- Co-authored-by: xsalonx <65893715+xsalonx@users.noreply.github.com> Co-authored-by: SandroBoelsz <97670955+SandroBoelsz@users.noreply.github.com> * test: add tests for filter feature --------- Co-authored-by: xsalonx <65893715+xsalonx@users.noreply.github.com> Co-authored-by: Martin Boulais <31805063+martinboulais@users.noreply.github.com> Co-authored-by: SandroBoelsz <97670955+SandroBoelsz@users.noreply.github.com> * feat: add status history filter * test: add tests for new filter * refactor: implement new status acronym legend * feat: add environment filter for run numbers * test: add tests for new feature * feat: use sequelize query for run number * Collinhva/o2 b 1109/environment filter status history (#1353) * [O2B-1107] Filter on environment id (#1326) * feat: add like filtering for ids * feat: add exact filter for environment ids * fix: fix lint problems * refactor: implement comment on PR * test: add tests for feature * test: add test for filtering in API * test: add more tests for environment API * [O2B-1125] Use scheduled process manager for synchronisation with MonALISA (#1340) * instnatiate synchronzier * typo * use const instead of class property * [O2B-1020] Bug fix for LHC Fill info disappearing (#1344) * fix: subsequently fetch the new run info after saving run update. * fix: cleaned up code for linter --------- Co-authored-by: Saif Rashed <saifrashed@mbp-van-saif.kpn> * [O2B-1094] Add runs counts to lhc periods view (#1334) * calculate runsCount * add some color * add color * add test * amend test * rename * [O2B-1103] Environment history occurrences histogram (#1328) * [O2B-1103] implemented the environment history occurrences histogram * [O2B-1103] implemented changes requested in the API PR * [O2B-1103] additional fix for the PR changes * [O2B-1103] changed existing status acronyms in accordance to the RMreportW29_2023 * [O2B-1103] added a max displayed bin limit to the environmentHistoryOccurences chart --------- Co-authored-by: Martin Boulais <31805063+martinboulais@users.noreply.github.com> * Release 0.76.0 (#1349) * [O2B-1122] Use generic overview page model in LHC Periods model (#1336) * amend * docs * Remove chart dead code (#1350) * Collinhva/o2 b 1108/environment filter on current status (#1351) * temp * docs: add TODO * refactor: currentStatus without OR and AND, just OR * docs: add TODO * feat: current status filter * Collinhva/o2 b 1107/filter on environment (#1341) * remove clause 'other' (#1335) * test: add test for filtering in API * [O2B-1104] added explicit ordering by the created_at date to solve test failing sometimes (#1338) * test: add more tests for environment API --------- Co-authored-by: xsalonx <65893715+xsalonx@users.noreply.github.com> Co-authored-by: SandroBoelsz <97670955+SandroBoelsz@users.noreply.github.com> * test: add tests for filter feature * fix: fix merge conflicts * [O2-4106] Fix race condition in running protoc on RHEL8 (#1158) * [O2-4106] Fix race condition in running protoc * Remove commented code * Fix install missing target * Increment version * Copy include files --------- Co-authored-by: Martin Boulais <31805063+martinboulais@users.noreply.github.com> * [O2B-1107] Filter on environment id (#1326) * feat: add like filtering for ids * feat: add exact filter for environment ids * fix: fix lint problems * refactor: implement comment on PR * test: add tests for feature * test: add test for filtering in API * test: add more tests for environment API * [O2B-1125] Use scheduled process manager for synchronisation with MonALISA (#1340) * instnatiate synchronzier * typo * use const instead of class property * [O2B-1020] Bug fix for LHC Fill info disappearing (#1344) * fix: subsequently fetch the new run info after saving run update. * fix: cleaned up code for linter --------- Co-authored-by: Saif Rashed <saifrashed@mbp-van-saif.kpn> * [O2B-1094] Add runs counts to lhc periods view (#1334) * calculate runsCount * add some color * add color * add test * amend test * rename * [O2B-1103] Environment history occurrences histogram (#1328) * [O2B-1103] implemented the environment history occurrences histogram * [O2B-1103] implemented changes requested in the API PR * [O2B-1103] additional fix for the PR changes * [O2B-1103] changed existing status acronyms in accordance to the RMreportW29_2023 * [O2B-1103] added a max displayed bin limit to the environmentHistoryOccurences chart --------- Co-authored-by: Martin Boulais <31805063+martinboulais@users.noreply.github.com> * Release 0.76.0 (#1349) * temp, not yet working, but closer * [O2B-1122] Use generic overview page model in LHC Periods model (#1336) * amend * docs * refactor: use sequelize query for status filter * fix: sequelize query not working * cleanup * refactor: restore unnecessary enters --------- Co-authored-by: xsalonx <65893715+xsalonx@users.noreply.github.com> Co-authored-by: SandroBoelsz <97670955+SandroBoelsz@users.noreply.github.com> Co-authored-by: Adam Wegrzynek <awegrzyn@users.noreply.github.com> Co-authored-by: Martin Boulais <31805063+martinboulais@users.noreply.github.com> Co-authored-by: Saif <38007030+saifrashed@users.noreply.github.com> Co-authored-by: Saif Rashed <saifrashed@mbp-van-saif.kpn> * refactor: use sequelize query instead of js filter * test: add limit tests as requested in previous pr --------- Co-authored-by: xsalonx <65893715+xsalonx@users.noreply.github.com> Co-authored-by: Saif <38007030+saifrashed@users.noreply.github.com> Co-authored-by: Saif Rashed <saifrashed@mbp-van-saif.kpn> Co-authored-by: SandroBoelsz <97670955+SandroBoelsz@users.noreply.github.com> Co-authored-by: Martin Boulais <31805063+martinboulais@users.noreply.github.com> Co-authored-by: Adam Wegrzynek <awegrzyn@users.noreply.github.com> * fix: merge conflicts * feat+test: add run number filter with sequelize query + limit tests * feat: add like query for run numbers filter * refactor: implement requested changes * test: improve test names + fix merge conflicts * fix: fix length of run numbers filter undefined --------- Co-authored-by: CollinHva <70367582+CollinHva@users.noreply.github.com> Co-authored-by: xsalonx <65893715+xsalonx@users.noreply.github.com> Co-authored-by: Martin Boulais <31805063+martinboulais@users.noreply.github.com> Co-authored-by: SandroBoelsz <97670955+SandroBoelsz@users.noreply.github.com> Co-authored-by: Saif <38007030+saifrashed@users.noreply.github.com> Co-authored-by: Saif Rashed <saifrashed@mbp-van-saif.kpn> Co-authored-by: Adam Wegrzynek <awegrzyn@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I DON'T have JIRA ticket
I have a JIRA ticket
Notable changes for users:
Notable changes for developers:
Changes made to the database: