Skip to content

[O2B-1106] Separate log reply from log creation#1388

Merged
martinboulais merged 6 commits into
mainfrom
mboulais/O2B-1106/separate-log-reply
Feb 12, 2024
Merged

[O2B-1106] Separate log reply from log creation#1388
martinboulais merged 6 commits into
mainfrom
mboulais/O2B-1106/separate-log-reply

Conversation

@martinboulais

Copy link
Copy Markdown
Contributor

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for developers:

  • Log reply has its dedicated page

@martinboulais martinboulais self-assigned this Feb 7, 2024
@martinboulais
martinboulais force-pushed the mboulais/O2B-1106/separate-log-reply branch 2 times, most recently from c9d289d to f3f96cb Compare February 9, 2024 10:07
@martinboulais
martinboulais force-pushed the mboulais/O2B-1106/separate-log-reply branch from f3f96cb to 59c7d99 Compare February 12, 2024 09:14
@martinboulais
martinboulais force-pushed the mboulais/O2B-1106/separate-log-reply branch from 59c7d99 to fb9e961 Compare February 12, 2024 09:20
@martinboulais
martinboulais marked this pull request as ready for review February 12, 2024 09:21
@codecov

codecov Bot commented Feb 12, 2024

Copy link
Copy Markdown

Codecov Report

Attention: 101 lines in your changes are missing coverage. Please review.

Comparison is base (a6d9a8a) 45.06% compared to head (a143771) 45.01%.

❗ Current head a143771 differs from pull request most recent head abb5520. Consider uploading reports for the commit abb5520 to get more accurate results

Files Patch % Lines
...b/public/views/Logs/Create/logCreationComponent.js 0.00% 26 Missing ⚠️
lib/public/views/Logs/Create/LogReplyModel.js 0.00% 21 Missing ⚠️
lib/public/views/Logs/LogsModel.js 0.00% 20 Missing ⚠️
lib/public/views/Logs/Create/logReplyComponent.js 0.00% 11 Missing ⚠️
lib/public/views/Logs/Create/LogCreationModel.js 0.00% 8 Missing ⚠️
lib/public/views/Logs/Create/LogReplyPage.js 0.00% 4 Missing ⚠️
lib/public/Model.js 0.00% 3 Missing ⚠️
...mponents/common/panel/LabelPanelHeaderComponent.js 0.00% 3 Missing ⚠️
...b/public/components/common/panel/PanelComponent.js 0.00% 3 Missing ⚠️
...iews/Logs/Create/panels/LogCreationContentPanel.js 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1388      +/-   ##
==========================================
- Coverage   45.06%   45.01%   -0.05%     
==========================================
  Files         733      739       +6     
  Lines       11841    11854      +13     
  Branches     2144     2137       -7     
==========================================
  Hits         5336     5336              
- Misses       6505     6518      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martinboulais
martinboulais merged commit 89ca6b4 into main Feb 12, 2024
@martinboulais
martinboulais deleted the mboulais/O2B-1106/separate-log-reply branch February 12, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants