[core] Counting number of status updates in transition_deploy#679
Closed
justonedev1 wants to merge 1 commit intomasterfrom
Closed
[core] Counting number of status updates in transition_deploy#679justonedev1 wants to merge 1 commit intomasterfrom
justonedev1 wants to merge 1 commit intomasterfrom
Conversation
knopers8
requested changes
Apr 2, 2025
Collaborator
knopers8
left a comment
There was a problem hiding this comment.
I'm afraid we are relying here on a quite far-fetched assumption that there is always just one status update per leaf. Even if this is correct now, we risk breaking this optimization if something changes about it in the future.
I would rather investigate if we could have a stupid channel listening for any deployment failure of a critical task and abort accordingly this loop in case that happens.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@knopers8 Do you think, that this can work for making environment deployment fail faster? I am not sure whether number of leafs gathered from
LeafWalkcan be comparable to the total amount status updates that we are receiving.I tested that only on my openstack with 5 tasks. But if you think that it is worth investigating, I can take a look at staging