[OCTRL-1018] Once NewEnvironmentAsync returns, the env should exist#710
[OCTRL-1018] Once NewEnvironmentAsync returns, the env should exist#710justonedev1 wants to merge 1 commit intomasterfrom
Conversation
justonedev1
changed the title
|
I split |
| Id: id.String(), | ||
| CreatedWhen: time.Now().UnixMilli(), | ||
| State: "ERROR", // not really, but close | ||
| NumberOfFlps: 0, |
There was a problem hiding this comment.
would it be difficult to have a correct value for the NumberOfFlps?
There was a problem hiding this comment.
no idea, I didn't change anything, I just split the code.
| workflowTemplate := request.GetWorkflowTemplate() | ||
| requestUser := request.GetRequestUser() | ||
|
|
||
| id, err = m.state.environments.CreateEnvironment(request.GetWorkflowTemplate(), userVars, request.GetPublic(), id) |
There was a problem hiding this comment.
One has to recognize that this will move environment creation into the synchronous part, which is a change in the behaviour. I imagine that the creation of an environment with all FLPs and no cached workflow templates may take 1-2 minutes. Please make sure that this is OK with George.
There was a problem hiding this comment.
I know, but this is the only way how to achieve George's desired behavior without changing order of operations and other code changes.
And it is also the reason why I gave binary with these changes to STG for him to play with so he can see how it will behave.
I also don't want to merge this before he okays this
|
I am closing this as George doesn't want this if it takes too long and he will add some workaround in GUI |
2 participants
No description provided.