Added of ZDC EPN QC#637
Merged
Merged
Conversation
lucaquaglia15
requested review from
chiarazampolli,
davidrohr,
martenole and
shahor02
as code owners
September 20, 2022 15:41
martenole
reviewed
Sep 20, 2022
martenole
left a comment
martenole
left a comment
Contributor
There was a problem hiding this comment.
Thanks! I think only the one hostname needs to be adapted, since the others are exchanged automatically. But I am still working on the test so I am not 100% sure. Then for the QC json I checked that the detector QC will always be added when ZDC is present. But since it might be that ZDC is included in the run, but the reconstruction is off, we need to add that one condition so that the ZDC QC is only enabled when the input it relies on is also available
Added the check to see if reconstruction is enabled Co-authored-by: Ole Schmidt <ole.schmidt@cern.ch>
Check if reconstruction is enabled Co-authored-by: Ole Schmidt <ole.schmidt@cern.ch>
Change of .json file wrt consul not to flood alice db during test runs Co-authored-by: Ole Schmidt <ole.schmidt@cern.ch>
martenole
approved these changes
Sep 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed with Ole, we created the PR to implement the ZDC QC on EPN
!!Important: we did not yet modify the url and conditionDB in the .json file, please have a look