margins for threshold tuning#646
Conversation
benedikt-voelkel
left a comment
benedikt-voelkel
left a comment
There was a problem hiding this comment.
You are computing the new threshold here already which will then be passed to the macro. As far as I can see, all margins and this file are passed to the macro where then again the margin is multiplied. That seems a duplication. In fact it should be enough to do the computation here and nothing ales needs to be passed to the macro.
| if t["test_name"] not in REL_VAL_TEST_NAMES_MAP: | ||
| continue | ||
| ind = REL_VAL_TEST_NAMES_MAP[t['test_name']] | ||
| f.write(f"{histo_name},{t['test_name']},{t['value']*threshold_margins[ind]}\n") |
There was a problem hiding this comment.
You are computing the new threshold here already which will then be passed to the macro. As far as I can see, all margins and this file are passed to the macro where then again the margin is multiplied. That seems a duplication. In fact it should be enough to do the computation here and nothing ales needs to be passed to the macro.
There was a problem hiding this comment.
You are right. I missed that the root macro is not actually reading from the .json file but from use_thresholds.dat produced by the python script
2 participants
No description provided.