Skip to content

[PWGDQ] ignore pdg code in paired tracks definition + other minor fixes#15990

Merged
mcoquet642 merged 4 commits intoAliceO2Group:masterfrom
aferrero2707:PWGDQ-ignore-pdg-code-in-paired-tracks-definition
Apr 28, 2026
Merged

[PWGDQ] ignore pdg code in paired tracks definition + other minor fixes#15990
mcoquet642 merged 4 commits intoAliceO2Group:masterfrom
aferrero2707:PWGDQ-ignore-pdg-code-in-paired-tracks-definition

Conversation

@aferrero2707
Copy link
Copy Markdown
Contributor

@aferrero2707 aferrero2707 commented Apr 28, 2026

List of changes:

  • removed condition on PDG particle code for paired MFT-MCH tracks
  • updated the ML training data producer task to reflect the paired tracks definition used in the QA task, removing the condition that the MFT and MCH tracks should be associated to the same collision (since the matching is collision agnostic).
  • use chi2 to sort matches obtained with chi2-based methods
  • fix boundaries of loop over collisions
  • add one more bin to the match type histograms, to also include the "undefined" category

@aferrero2707
[PWGDQ] removed condition on PDG particle code for paired MFT-MCH tracks
dccc66e 
The commit also updated the ML training data producer task to reflect the
paired tracks definition used in the QA task, removing the condition that
the MFT and MCH tracks should be associated to the same collision (since
the matching is collision agnostic).
@aferrero2707
[PWGDQ] use chi2 to sort matches obtained with chi2-based methods
4e5f96b 
Since the matching score derived from the chi2 has a worse numerical
precision, it is better to do the sorting on the original chi2 value
obtained from the matching function.
@aferrero2707
[PWGDQ] minor fixes
4ab4c58 
- fix boundaries of loop over collisions
- add one more bin to the match type histograms, to also include the
"undefined" cathegory
@github-actions github-actions Bot added the pwgdq label Apr 28, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 28, 2026 •
edited
Loading

O2 linter results: ❌ 29 errors, ⚠️ 12 warnings, 🔕 0 disabled

@alibuild
Copy link
Copy Markdown
Collaborator

alibuild commented Apr 28, 2026

Error while checking build/O2Physics/o2 for 4ab4c58 at 2026-04-28 11:25:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Tasks/mftMchMatcher.cxx:476:12: error: unused variable 'muonCollisionId' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Tasks/mftMchMatcher.cxx:463:26: error: unused variable 'muonPdgCode' [-Werror=unused-variable]
ninja: build stopped: subcommand failed.

Full log here.

@mcoquet642 mcoquet642 merged commit 8fcb776 into AliceO2Group:master Apr 28, 2026
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcoquet642 mcoquet642 mcoquet642 approved these changes

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@iarsene iarsene Awaiting requested review from iarsene iarsene is a code owner

@lucamicheletti93 lucamicheletti93 Awaiting requested review from lucamicheletti93 lucamicheletti93 is a code owner

Assignees

No one assigned

Labels

pwgdq

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aferrero2707 @alibuild @mcoquet642