Skip to content

[PWGLF] Fix v0 radius cut condition#16999

Merged
lhusova merged 2 commits into
AliceO2Group:masterfrom
nepeivodaRS:v0radius-fix
Jul 10, 2026
Merged

[PWGLF] Fix v0 radius cut condition#16999
lhusova merged 2 commits into
AliceO2Group:masterfrom
nepeivodaRS:v0radius-fix

Conversation

@nepeivodaRS

@nepeivodaRS nepeivodaRS commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Fixes the bug in the v0 radius selection.

@github-actions github-actions Bot added the pwglf label Jul 10, 2026
@github-actions

github-actions Bot commented Jul 10, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 25 errors, ⚠️ 8 warnings, 🔕 0 disabled

@nepeivodaRS nepeivodaRS marked this pull request as ready for review July 10, 2026 07:51
@lhusova lhusova enabled auto-merge (squash) July 10, 2026 08:00
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 5e92559 at 2026-07-10 10:10:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 7 errors and 26 warnings.'
Found 7 errors and 26 warnings.
++ [[ 7 -gt 0 ]]
++ cat /sw/BUILD/c226e0ce8313f6a58afbbd72f8be26b6792cda4f/O2Physics-code-check/errors.txt
PWGLF/Tasks/Strangeness/v0postprocessing.cxx:91:58: error: implicit conversion 'bool' -> 'Double_t' (aka 'double') [readability-implicit-bool-conversion,-warnings-as-errors]
PWGLF/Tasks/Strangeness/v0postprocessing.cxx:97:58: error: implicit conversion 'bool' -> 'Double_t' (aka 'double') [readability-implicit-bool-conversion,-warnings-as-errors]
PWGLF/Tasks/Strangeness/v0postprocessing.cxx:98:58: error: implicit conversion 'bool' -> 'Double_t' (aka 'double') [readability-implicit-bool-conversion,-warnings-as-errors]
PWGLF/Tasks/Strangeness/v0postprocessing.cxx:111:80: error: implicit conversion 'bool' -> 'float' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGLF/Tasks/Strangeness/v0postprocessing.cxx:418:13: error: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGLF/Tasks/Strangeness/v0postprocessing.cxx:458:17: error: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGLF/Tasks/Strangeness/v0postprocessing.cxx:497:17: error: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion,-warnings-as-errors]
++ [[ 26 -gt 0 ]]
++ cat /sw/BUILD/c226e0ce8313f6a58afbbd72f8be26b6792cda4f/O2Physics-code-check/warnings.txt
PWGLF/Tasks/Strangeness/v0postprocessing.cxx:231:41: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/v0postprocessing.cxx:235:39: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/v0postprocessing.cxx:239:44: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/v0postprocessing.cxx:243:92: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/v0postprocessing.cxx:247:58: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/v0postprocessing.cxx:251:58: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/v0postprocessing.cxx:255:99: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/v0postprocessing.cxx:266:41: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/v0postprocessing.cxx:270:75: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/v0postprocessing.cxx:274:49: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/v0postprocessing.cxx:276:49: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/v0postprocessing.cxx:280:57: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/v0postprocessing.cxx:282:57: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/v0postprocessing.cxx:286:49: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/v0postprocessing.cxx:290:47: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/v0postprocessing.cxx:292:47: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/v0postprocessing.cxx:296:72: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/v0postprocessing.cxx:300:74: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/v0postprocessing.cxx:304:61: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/v0postprocessing.cxx:306:61: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/v0postprocessing.cxx:310:59: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/v0postprocessing.cxx:312:59: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/v0postprocessing.cxx:316:52: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/v0postprocessing.cxx:318:52: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/v0postprocessing.cxx:322:52: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/v0postprocessing.cxx:324:52: warning: statement should be inside braces [readability-braces-around-statements]
++ [[ 7 -gt 0 ]]
++ exit 1
--

Full log here.

@lhusova lhusova merged commit c1ebdde into AliceO2Group:master Jul 10, 2026
13 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants