Skip to content

[PWGEM/Dilepton] remove unused configurable variables#17057

Merged
dsekihat merged 1 commit into
AliceO2Group:masterfrom
dsekihat:master
Jul 14, 2026
Merged

[PWGEM/Dilepton] remove unused configurable variables#17057
dsekihat merged 1 commit into
AliceO2Group:masterfrom
dsekihat:master

Conversation

@dsekihat

Copy link
Copy Markdown
Collaborator

[PWGEM/Dilepton] remove unused configurable variables

@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 960 errors, ⚠️ 1185 warnings, 🔕 0 disabled

@dsekihat dsekihat enabled auto-merge (squash) July 14, 2026 11:40

@alibuild alibuild left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @dsekihat.

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 36af7c2 at 2026-07-14 13:46:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 145 errors and 4 warnings.'
Found 145 errors and 4 warnings.
++ [[ 145 -gt 0 ]]
++ cat /sw/BUILD/0dbfae21fb0b4ef2c618ad74cf00f31b394f2d2a/O2Physics-code-check/errors.txt
PWGEM/Dilepton/Core/DileptonMC.h:82:10: error: inclusion of deprecated C++ header 'math.h'; consider using 'cmath' instead [modernize-deprecated-headers,-warnings-as-errors]
PWGEM/Dilepton/Core/DileptonMC.h:108:8: error: constructor does not initialize these fields: ccdb, mRunNumber, d_bz [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGEM/Dilepton/Core/DileptonMC.h:335:20: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGEM/Dilepton/Core/DileptonMC.h:336:20: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGEM/Dilepton/Core/DileptonMC.h:337:20: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGEM/Dilepton/Core/DileptonMC.h:359:20: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGEM/Dilepton/Core/DileptonMC.h:361:3: error: use '= default' to define a trivial destructor [modernize-use-equals-default,-warnings-as-errors]
PWGEM/Dilepton/Core/DileptonMC.h:451:22: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGEM/Dilepton/Core/DileptonMC.h:452:22: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGEM/Dilepton/Core/DileptonMC.h:454:22: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGEM/Dilepton/Core/DileptonMC.h:455:22: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGEM/Dilepton/Core/DileptonMC.h:457:22: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGEM/Dilepton/Core/DileptonMC.h:458:22: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGEM/Dilepton/Core/DileptonMC.h:517:32: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGEM/Dilepton/Core/DileptonMC.h:667:39: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
PWGEM/Dilepton/Core/DileptonMC.h:668:43: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
PWGEM/Dilepton/Core/DileptonMC.h:821:5: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGEM/Dilepton/Core/DileptonMC.h:835:38: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGEM/Dilepton/Core/DileptonMC.h:843:5: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGEM/Dilepton/Core/DileptonMC.h:850:38: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGEM/Dilepton/Core/DileptonMC.h:858:5: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGEM/Dilepton/Core/DileptonMC.h:865:38: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGEM/Dilepton/Core/DileptonMC.h:907:14: error: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr,-warnings-as-errors]
PWGEM/Dilepton/Core/DileptonMC.h:908:7: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGEM/Dilepton/Core/DileptonMC.h:1413:7: error: if with identical then and else branches [bugprone-branch-clone,-warnings-as-errors]
PWGEM/Dilepton/Core/DileptonMC.h:2066:7: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGEM/Dilepton/Core/DileptonMC.h:2114:7: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGEM/Dilepton/Core/DileptonMC.h:2166:7: error: if with identical then and else branches [bugprone-branch-clone,-warnings-as-errors]
PWGEM/Dilepton/Core/DileptonMC.h:2190:105: error: repeated branch body in conditional chain [bugprone-branch-clone,-warnings-as-errors]
PWGEM/Dilepton/Core/DileptonMC.h:2211:13: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGEM/Dilepton/Core/DileptonMC.h:2471:9: error: switch has 4 consecutive identical branches [bugprone-branch-clone,-warnings-as-errors]
PWGEM/Dilepton/Core/DileptonMC.h:2495:7: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGEM/Dilepton/Core/DileptonMC.h:2635:7: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGEM/Dilepton/Core/DileptonSVMC.h:86:10: error: inclusion of deprecated C++ header 'math.h'; consider using 'cmath' instead [modernize-deprecated-headers,-warnings-as-errors]
PWGEM/Dilepton/Core/DileptonSVMC.h:112:8: error: constructor does not initialize these fields: ccdb [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGEM/Dilepton/Core/DileptonSVMC.h:368:20: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGEM/Dilepton/Core/DileptonSVMC.h:369:20: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGEM/Dilepton/Core/DileptonSVMC.h:370:20: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGEM/Dilepton/Core/DileptonSVMC.h:392:20: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGEM/Dilepton/Core/DileptonSVMC.h:394:3: error: use '= default' to define a trivial destructor [modernize-use-equals-default,-warnings-as-errors]
PWGEM/Dilepton/Core/DileptonSVMC.h:490:22: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGEM/Dilepton/Core/DileptonSVMC.h:491:22: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
[0 more errors; see full log]

Full log here.

@dsekihat dsekihat merged commit a053f3c into AliceO2Group:master Jul 14, 2026
13 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants