Skip to content

[PWGDQ] add some fgVarNamesMap related to A2 analysis - #17127

Merged
XiaozhiBai merged 5 commits into
AliceO2Group:masterfrom
ypwangg:update-varNamesMap-in-A2
Jul 30, 2026
Merged

[PWGDQ] add some fgVarNamesMap related to A2 analysis#17127
XiaozhiBai merged 5 commits into
AliceO2Group:masterfrom
ypwangg:update-varNamesMap-in-A2

Conversation

@ypwangg

@ypwangg ypwangg commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions github-actions Bot added the pwgdq label Jul 20, 2026
@github-actions github-actions Bot changed the title add some fgVarNamesMap related to A2 analysis [PWGDQ] add some fgVarNamesMap related to A2 analysis Jul 20, 2026
@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 6 errors, ⚠️ 18 warnings, 🔕 0 disabled

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 0e5c388 at 2026-07-20 11:34:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 35 errors and 0 warnings.'
Found 35 errors and 0 warnings.
++ [[ 35 -gt 0 ]]
++ cat /sw/BUILD/cc0c8d671469544e30b547ee644d9898556c9d71/O2Physics-code-check/errors.txt
PWGDQ/Core/VarManager.cxx:47:1: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:48:1: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:50:1: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:56:1: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:80:28: error: initializer for base class 'TObject' is redundant [readability-redundant-member-init,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:134:14: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:142:45: error: the parameter 'system' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:195:43: error: result of integer division used in a floating point context; possible loss of precision [bugprone-integer-division,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:196:43: error: result of integer division used in a floating point context; possible loss of precision [bugprone-integer-division,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:238:45: error: the parameter 'kfp' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:238:61: error: the parameter 'PV' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:251:18: error: variable 'calibMean' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:251:29: error: variable 'calibSigma' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:274:27: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:275:28: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:295:5: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:297:18: error: variable 'calibMean' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:297:29: error: variable 'calibSigma' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:297:41: error: variable 'calibStatus' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:324:27: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:325:28: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:326:29: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:346:5: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:347:66: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:348:48: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:349:50: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:369:7: error: switch has 2 consecutive identical branches [bugprone-branch-clone,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:403:14: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:414:28: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:434:28: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:468:9: error: variable 'diff' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:468:15: error: variable 'diff2' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:615:9: error: variable 'diff' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:615:15: error: variable 'diff2' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:615:22: error: variable 'binCenter' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
++ [[ 0 -gt 0 ]]
++ [[ 35 -gt 0 ]]
++ exit 1
--

Full log here.

@alibuild

alibuild commented Jul 23, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 1d6a66d at 2026-07-23 08:32:

## sw/BUILD/O2Physics-latest/log
c++: fatal error: Killed signal terminated program cc1plus
ninja: build stopped: subcommand failed.

Full log here.

@ypwangg
ypwangg marked this pull request as draft July 23, 2026 14:00
@ypwangg
ypwangg marked this pull request as ready for review July 27, 2026 07:49
@alibuild

alibuild commented Jul 27, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 08273c7 at 2026-07-30 05:09:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 40 errors and 0 warnings.'
Found 40 errors and 0 warnings.
++ [[ 40 -gt 0 ]]
++ cat /sw/BUILD/597b65ddf64b5907d9d5a353eb3b580b741315b6/O2Physics-code-check/errors.txt
PWGDQ/Core/VarManager.cxx:48:1: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:49:1: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:51:1: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:57:1: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:83:28: error: initializer for base class 'TObject' is redundant [readability-redundant-member-init,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:137:14: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:145:45: error: the parameter 'system' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:198:43: error: result of integer division used in a floating point context; possible loss of precision [bugprone-integer-division,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:199:43: error: result of integer division used in a floating point context; possible loss of precision [bugprone-integer-division,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:241:45: error: the parameter 'kfp' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:241:61: error: the parameter 'PV' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:254:18: error: variable 'calibMean' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:254:29: error: variable 'calibSigma' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:277:27: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:278:28: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:298:5: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:300:18: error: variable 'calibMean' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:300:29: error: variable 'calibSigma' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:300:41: error: variable 'calibStatus' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:327:27: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:328:28: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:329:29: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:349:5: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:350:66: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:351:48: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:352:50: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:372:7: error: switch has 2 consecutive identical branches [bugprone-branch-clone,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:406:14: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:417:28: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:437:28: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:472:12: error: no header providing "gRandom" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:472:54: error: no header providing "o2::constants::math::TwoPI" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:473:5: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:522:7: error: no header providing "RecoDecay" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:541:9: error: variable 'diff' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:541:15: error: variable 'diff2' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:688:9: error: variable 'diff' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:688:15: error: variable 'diff2' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:688:22: error: variable 'binCenter' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGDQ/Core/VarManager.h:1537:15: error: function 'VarManager::SetPhiMap' has a definition with different parameter names [readability-inconsistent-declaration-parameter-name,-warnings-as-errors]
++ [[ 0 -gt 0 ]]
++ [[ 40 -gt 0 ]]
[0 more errors; see full log]

Full log here.

@XiaozhiBai
XiaozhiBai enabled auto-merge (squash) July 30, 2026 14:49
@XiaozhiBai
XiaozhiBai merged commit 32257cb into AliceO2Group:master Jul 30, 2026
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants