Skip to content

[PWGLF] changes in the tree creator for cluster size studies - #17237

Merged
maciacco merged 2 commits into
AliceO2Group:masterfrom
GiorgioAlbertoLucia:its
Jul 29, 2026
Merged

[PWGLF] changes in the tree creator for cluster size studies#17237
maciacco merged 2 commits into
AliceO2Group:masterfrom
GiorgioAlbertoLucia:its

Conversation

@GiorgioAlbertoLucia

@GiorgioAlbertoLucia GiorgioAlbertoLucia commented Jul 28, 2026

Copy link
Copy Markdown
Contributor
  • added nsigmatpc selection for the V0 daughters in the cascade routine
  • moved the invariant mass histogram construction after the nsigmatpc selection on the K

@github-actions github-actions Bot added the pwglf label Jul 28, 2026
@github-actions

github-actions Bot commented Jul 28, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 26 errors, ⚠️ 21 warnings, 🔕 0 disabled

@GiorgioAlbertoLucia
GiorgioAlbertoLucia marked this pull request as ready for review July 28, 2026 15:53
@alibuild

alibuild commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for cc67b48 at 2026-07-28 18:02:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:914:111: error: unused parameter 'v0s' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:914:111: error: unused parameter 'v0s' [-Werror=unused-parameter]
ninja: build stopped: subcommand failed.

Full log here.

@alibuild

alibuild commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for cc67b48 at 2026-07-28 18:04:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:914:111: error: unused parameter 'v0s' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:914:111: error: unused parameter 'v0s' [-Werror=unused-parameter]
ninja: build stopped: subcommand failed.

Full log here.

@alibuild

alibuild commented Jul 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for cc67b48 at 2026-07-29 04:19:

## sw/BUILD/O2Physics-latest/log
2026-07-29T03:58:16.962+0200 [23:140545761651264] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-07-29T03:58:16.962+0200 [23:140545761651264] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused
2026-07-29T04:00:01.176+0200 [23:140545761651264] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "FindMissingBlobs()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv6:%5B::1%5D:8980: Failed to connect to remote host: Connection refused]
2026-07-29T03:58:16.849+0200 [24:140466646563392] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-07-29T03:58:16.849+0200 [24:140466646563392] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused
2026-07-29T04:01:34.587+0200 [24:140466646563392] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "FindMissingBlobs()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv6:%5B::1%5D:8980: Failed to connect to remote host: Connection refused]


## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 6 errors and 8 warnings.'
Found 6 errors and 8 warnings.
++ [[ 6 -gt 0 ]]
++ cat /sw/BUILD/02c8bc2c003ec45df65dee7e75a8817c867f03e6/O2Physics-code-check/errors.txt
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:167:8: error: constructor does not initialize these fields: mccdb [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:412:14: error: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:727:14: error: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:761:43: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:914:111: error: parameter 'v0s' is unused [misc-unused-parameters,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:914:111: error: unused parameter 'v0s' [clang-diagnostic-unused-parameter,-warnings-as-errors]
++ [[ 8 -gt 0 ]]
++ cat /sw/BUILD/02c8bc2c003ec45df65dee7e75a8817c867f03e6/O2Physics-code-check/warnings.txt
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:606:90: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:826:47: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:830:51: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:834:55: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:838:49: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:842:48: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:1002:44: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:1444:68: warning: statement should be inside braces [readability-braces-around-statements]
++ [[ 6 -gt 0 ]]
++ exit 1
--

Full log here.

@GiorgioAlbertoLucia
GiorgioAlbertoLucia marked this pull request as draft July 29, 2026 07:20
@GiorgioAlbertoLucia
added nsigmatpc selection for the V0 daughters in the cascade routine…
03e7aff 
…, moved the invariant mass histogram construction after the nsigmatpc selection on the K
@GiorgioAlbertoLucia
removed unusued variable and solved linter issues
281de79
@GiorgioAlbertoLucia
GiorgioAlbertoLucia marked this pull request as ready for review July 29, 2026 07:27
@alibuild

alibuild commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 281de79 at 2026-07-29 10:18:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 3 errors and 0 warnings.'
Found 3 errors and 0 warnings.
++ [[ 3 -gt 0 ]]
++ cat /sw/BUILD/14884867a00e759df3023d89f49f7b50fefc32fd/O2Physics-code-check/errors.txt
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:167:8: error: constructor does not initialize these fields: mccdb [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:412:14: error: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:728:14: error: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr,-warnings-as-errors]
++ [[ 0 -gt 0 ]]
++ [[ 3 -gt 0 ]]
++ exit 1
--

Full log here.

@maciacco
maciacco enabled auto-merge (squash) July 29, 2026 09:10
@maciacco
maciacco merged commit 78c1280 into AliceO2Group:master Jul 29, 2026
12 of 14 checks passed
@GiorgioAlbertoLucia
GiorgioAlbertoLucia deleted the its branch July 29, 2026 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maciacco maciacco maciacco approved these changes
@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner
@omvazque omvazque Awaiting requested review from omvazque omvazque is a code owner
@skundu692 skundu692 Awaiting requested review from skundu692 skundu692 is a code owner
@mpuccio mpuccio Awaiting requested review from mpuccio mpuccio is a code owner
@fmazzasc fmazzasc Awaiting requested review from fmazzasc fmazzasc is a code owner
@HorstMa HorstMa Awaiting requested review from HorstMa HorstMa is a code owner

Assignees

No one assigned

Labels

pwglf

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@GiorgioAlbertoLucia @alibuild @maciacco