Skip to content

[PWGDQ] implementing a posteriori 3D vertex shift for forward tracks - #17281

Merged
mcoquet642 merged 1 commit into
AliceO2Group:masterfrom
mcoquet642:dq-3d-vtx-shift-2
Aug 3, 2026
Merged

[PWGDQ] implementing a posteriori 3D vertex shift for forward tracks#17281
mcoquet642 merged 1 commit into
AliceO2Group:masterfrom
mcoquet642:dq-3d-vtx-shift-2

Conversation

@mcoquet642

Copy link
Copy Markdown
Collaborator

No description provided.

@github-actions

github-actions Bot commented Aug 1, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 111 errors, ⚠️ 732 warnings, 🔕 0 disabled

@alibuild

alibuild commented Aug 2, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 18a6cae at 2026-08-03 14:21:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 95 errors and 0 warnings.'
Found 95 errors and 0 warnings.
++ [[ 95 -gt 0 ]]
++ cat /sw/BUILD/d47cee4e249b4582dc8001e5c19dda085f3224dc/O2Physics-code-check/errors.txt
PWGDQ/Core/VarManager.cxx:51:1: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:52:1: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:54:1: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:62:1: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:88:28: error: initializer for base class 'TObject' is redundant [readability-redundant-member-init,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:142:14: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:150:45: error: the parameter 'system' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:203:43: error: result of integer division used in a floating point context; possible loss of precision [bugprone-integer-division,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:204:43: error: result of integer division used in a floating point context; possible loss of precision [bugprone-integer-division,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:246:45: error: the parameter 'kfp' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:246:61: error: the parameter 'PV' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:259:18: error: variable 'calibMean' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:259:29: error: variable 'calibSigma' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:282:27: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:283:28: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:303:5: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:305:18: error: variable 'calibMean' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:305:29: error: variable 'calibSigma' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:305:41: error: variable 'calibStatus' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:332:27: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:333:28: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:334:29: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:354:5: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:355:66: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:356:48: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:357:50: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:377:7: error: switch has 2 consecutive identical branches [bugprone-branch-clone,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:411:14: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:422:28: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:442:28: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:478:5: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:544:9: error: variable 'diff' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:544:15: error: variable 'diff2' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:691:9: error: variable 'diff' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:691:15: error: variable 'diff2' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGDQ/Core/VarManager.cxx:691:22: error: variable 'binCenter' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGDQ/Core/VarManager.h:1205:10: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGDQ/Core/VarManager.h:1206:10: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGDQ/Core/VarManager.h:1545:15: error: function 'VarManager::SetPhiMap' has a definition with different parameter names [readability-inconsistent-declaration-parameter-name,-warnings-as-errors]
PWGDQ/Core/VarManager.h:1576:10: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGDQ/Core/VarManager.h:1580:10: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGDQ/Core/VarManager.h:1817:14: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
[0 more errors; see full log]

Full log here.

@mcoquet642
mcoquet642 enabled auto-merge (squash) August 3, 2026 11:39

@alibuild alibuild left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @mcoquet642.

@mcoquet642
mcoquet642 merged commit e6e9882 into AliceO2Group:master Aug 3, 2026
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants