Skip to content

[PWGEM,PWGHF] Clean up code-check errors and warnings - #17285

Merged
mhemmer-cern merged 3 commits into
AliceO2Group:masterfrom
mhemmer-cern:clean-up
Aug 3, 2026
Merged

[PWGEM,PWGHF] Clean up code-check errors and warnings#17285
mhemmer-cern merged 3 commits into
AliceO2Group:masterfrom
mhemmer-cern:clean-up

Conversation

@mhemmer-cern

Copy link
Copy Markdown
Collaborator

Clean up some code-check errors and warnings in the PWGEM/PhotonMeson/Utils part. Resulting changes affected also one code in HF so I touched that one file and fixed the things there too. I hope that's okay.

@github-actions

github-actions Bot commented Aug 1, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 181 errors, ⚠️ 300 warnings, 🔕 16 disabled

@mhemmer-cern
mhemmer-cern enabled auto-merge (squash) August 1, 2026 20:48
@mhemmer-cern
mhemmer-cern disabled auto-merge August 1, 2026 20:49
@alibuild

This comment was marked as outdated.

@mhemmer-cern
mhemmer-cern marked this pull request as draft August 2, 2026 11:53
@mhemmer-cern

Copy link
Copy Markdown
Collaborator Author

@vkucera something is wrong with the code-check result here.
PWGEM/PhotonMeson/Utils/ClusterHistograms.h:19:10: error: 'PWGEM/PhotonMeson/Core/EMCPhotonCut.h' file not found [clang-diagnostic-error]
The file is there and otherwise wouldn't compilation break?
PWGEM/PhotonMeson/Utils/ClusterHistograms.h:27:1: error: included header TH2.h is not used directly [misc-include-cleaner,-warnings-as-errors]
TH2 is used in line 74
array is used in line 117...
and so on.

Locally when checking my branch with these commit vs upstream/master I am not getting any of these false errors.

@vkucera

vkucera commented Aug 2, 2026

Copy link
Copy Markdown
Collaborator

@mhemmer-cern Indeed, I cannot reproduce it either locally. It seems like Clang-Tidy cannot find the correct compilation command for the header in the database.

@mhemmer-cern

Copy link
Copy Markdown
Collaborator Author

@mhemmer-cern Indeed, I cannot reproduce it either locally. It seems like Clang-Tidy cannot find the correct compilation command for the header in the database.

Then I will mark this a ready for review.

@mhemmer-cern

Copy link
Copy Markdown
Collaborator Author

@vkucera could you approve this if this is okay from HF side?

@vkucera vkucera left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mhemmer-cern , looks good to me. Also the code-check seems to have recovered.

@mhemmer-cern
mhemmer-cern enabled auto-merge (squash) August 3, 2026 12:28

@alibuild alibuild left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @mhemmer-cern.

@mhemmer-cern
mhemmer-cern merged commit a15dee1 into AliceO2Group:master Aug 3, 2026
14 of 16 checks passed
@mhemmer-cern
mhemmer-cern deleted the clean-up branch August 3, 2026 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

photon Photon and neutral meson PAG label pwgem pwghf PWG-HF

Development

Successfully merging this pull request may close these issues.

3 participants