Skip to content

[PWGCF] jEPFlowAnalysis.cxx: add angular selection for two leading tracks - #17291

Merged
wenyaCern merged 3 commits into
AliceO2Group:masterfrom
jikim1290:cf7
Aug 3, 2026
Merged

[PWGCF] jEPFlowAnalysis.cxx: add angular selection for two leading tracks#17291
wenyaCern merged 3 commits into
AliceO2Group:masterfrom
jikim1290:cf7

Conversation

@jikim1290

Copy link
Copy Markdown
Contributor

add angular selection for two leading tracks

@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 3 warnings, 🔕 0 disabled

@github-actions github-actions Bot added the pwgcf label Aug 3, 2026
Please consider the following formatting changes to AliceO2Group#17291
@alibuild

alibuild commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 015a390 at 2026-08-03 07:39:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 18 errors and 19 warnings.'
Found 18 errors and 19 warnings.
++ [[ 18 -gt 0 ]]
++ cat /sw/BUILD/caf10b2ee4253f1667181c86557292abdb1cbb26/O2Physics-code-check/errors.txt
PWGCF/JCorran/Tasks/jEPFlowAnalysis.cxx:75:8: error: constructor does not initialize these fields: pdg, ccdb [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGCF/JCorran/Tasks/jEPFlowAnalysis.cxx:207:40: error: initializer for member 'shiftprofile' is redundant [readability-redundant-member-init,-warnings-as-errors]
PWGCF/JCorran/Tasks/jEPFlowAnalysis.cxx:218:37: error: initializer for member 'ft0RelGainConst' is redundant [readability-redundant-member-init,-warnings-as-errors]
PWGCF/JCorran/Tasks/jEPFlowAnalysis.cxx:219:37: error: initializer for member 'fv0RelGainConst' is redundant [readability-redundant-member-init,-warnings-as-errors]
PWGCF/JCorran/Tasks/jEPFlowAnalysis.cxx:235:7: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGCF/JCorran/Tasks/jEPFlowAnalysis.cxx:247:31: error: repeated branch body in conditional chain [bugprone-branch-clone,-warnings-as-errors]
PWGCF/JCorran/Tasks/jEPFlowAnalysis.cxx:249:7: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGCF/JCorran/Tasks/jEPFlowAnalysis.cxx:271:5: error: switching on non-enum value without default case may not cover all cases [bugprone-switch-missing-default-case,-warnings-as-errors]
PWGCF/JCorran/Tasks/jEPFlowAnalysis.cxx:374:5: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/JCorran/Tasks/jEPFlowAnalysis.cxx:375:5: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/JCorran/Tasks/jEPFlowAnalysis.cxx:376:5: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/JCorran/Tasks/jEPFlowAnalysis.cxx:574:5: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/JCorran/Tasks/jEPFlowAnalysis.cxx:580:31: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGCF/JCorran/Tasks/jEPFlowAnalysis.cxx:655:9: error: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGCF/JCorran/Tasks/jEPFlowAnalysis.cxx:666:9: error: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGCF/JCorran/Tasks/jEPFlowAnalysis.cxx:774:9: error: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGCF/JCorran/Tasks/jEPFlowAnalysis.cxx:779:9: error: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGCF/JCorran/Tasks/jEPFlowAnalysis.cxx:815:11: error: implicit conversion 'uint8_t' (aka 'unsigned char') -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
++ [[ 19 -gt 0 ]]
++ cat /sw/BUILD/caf10b2ee4253f1667181c86557292abdb1cbb26/O2Physics-code-check/warnings.txt
PWGCF/JCorran/Tasks/jEPFlowAnalysis.cxx:269:44: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/JCorran/Tasks/jEPFlowAnalysis.cxx:273:26: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/JCorran/Tasks/jEPFlowAnalysis.cxx:277:136: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/JCorran/Tasks/jEPFlowAnalysis.cxx:282:120: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/JCorran/Tasks/jEPFlowAnalysis.cxx:286:81: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/JCorran/Tasks/jEPFlowAnalysis.cxx:291:114: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/JCorran/Tasks/jEPFlowAnalysis.cxx:294:59: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/JCorran/Tasks/jEPFlowAnalysis.cxx:445:48: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/JCorran/Tasks/jEPFlowAnalysis.cxx:462:41: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/JCorran/Tasks/jEPFlowAnalysis.cxx:467:50: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/JCorran/Tasks/jEPFlowAnalysis.cxx:470:116: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/JCorran/Tasks/jEPFlowAnalysis.cxx:473:66: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/JCorran/Tasks/jEPFlowAnalysis.cxx:529:46: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/JCorran/Tasks/jEPFlowAnalysis.cxx:682:27: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/JCorran/Tasks/jEPFlowAnalysis.cxx:765:122: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/JCorran/Tasks/jEPFlowAnalysis.cxx:795:27: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/JCorran/Tasks/jEPFlowAnalysis.cxx:830:33: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/JCorran/Tasks/jEPFlowAnalysis.cxx:843:63: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/JCorran/Tasks/jEPFlowAnalysis.cxx:853:43: warning: statement should be inside braces [readability-braces-around-statements]
++ [[ 18 -gt 0 ]]
++ exit 1
--
[0 more errors; see full log]

Full log here.

@wenyaCern
wenyaCern merged commit 2671c44 into AliceO2Group:master Aug 3, 2026
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants