Skip to content

[PWGLF] Adding discription for analysis and adding event flow and efficiency corrections - #17341

Merged
dmallick2 merged 3 commits into
AliceO2Group:masterfrom
bhattdurgesh921-sys:master
Aug 7, 2026
Merged

[PWGLF] Adding discription for analysis and adding event flow and efficiency corrections#17341
dmallick2 merged 3 commits into
AliceO2Group:masterfrom
bhattdurgesh921-sys:master

Conversation

@bhattdurgesh921-sys

Copy link
Copy Markdown
Contributor

Dear @dmallick2 ,
In this PR we have implemented the event-level correction framework for the Δ analysis by adding the Event Loss and Event Splitting calculations, corresponding QA and cut-flow histograms, and the truth-level INEL > 0 selection.

@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 4 warnings, 🔕 0 disabled

@github-actions github-actions Bot changed the title Adding discription for analysis and adding event flow and efficiency corrections [PWGLF] Adding discription for analysis and adding event flow and efficiency corrections Aug 5, 2026
@alibuild

alibuild commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 401a700 at 2026-08-05 16:30:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 4 errors and 0 warnings.'
Found 4 errors and 0 warnings.
++ [[ 4 -gt 0 ]]
++ cat /sw/BUILD/a7b56d8d321c7d74bb74dd6547c8a591165bb857/O2Physics-code-check/errors.txt
PWGLF/Tasks/Resonances/deltaAnalysis.cxx:80:8: error: constructor does not initialize these fields: pdgDB [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGLF/Tasks/Resonances/deltaAnalysis.cxx:86:3: error: no header providing "o2::framework::Service" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Resonances/deltaAnalysis.cxx:458:38: error: no header providing "TH1" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Resonances/deltaAnalysis.cxx:1655:59: error: use 'contains' to check for membership [readability-container-contains,-warnings-as-errors]
++ [[ 0 -gt 0 ]]
++ [[ 4 -gt 0 ]]
++ exit 1
--

Full log here.

@vkucera

vkucera commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

@bhattdurgesh921-sys Don't duplicate PRs. #17317

prottayCMT
prottayCMT previously approved these changes Aug 6, 2026
@prottayCMT
prottayCMT enabled auto-merge (squash) August 6, 2026 11:25
@vkucera
vkucera disabled auto-merge August 6, 2026 11:43
@vkucera

vkucera commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

@prottayCMT Don't merge untested PRs.

@alibuild

alibuild commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for d984e6f at 2026-08-06 19:58:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 1 errors and 0 warnings.'
Found 1 errors and 0 warnings.
++ [[ 1 -gt 0 ]]
++ cat /sw/BUILD/a811a0b6e9b437e35925b360591e7c990832aa4d/O2Physics-code-check/errors.txt
PWGLF/Tasks/Resonances/deltaAnalysis.cxx:88:3: error: no header providing "o2::framework::Service" is directly included [misc-include-cleaner,-warnings-as-errors]
++ [[ 0 -gt 0 ]]
++ [[ 1 -gt 0 ]]
++ exit 1
--

Full log here.

@vkucera vkucera left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bhattdurgesh921-sys Fix the error and next time, test your PR locally first.

@bhattdurgesh921-sys

Copy link
Copy Markdown
Contributor Author

Dear @vkucera ,
Coulrd you please approve the PR .All checks are passed .

@vkucera

vkucera commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator

Dear @vkucera , Coulrd you please approve the PR .All checks are passed .

Since you are the only author of the file, please fix the warnings as well.

@bhattdurgesh921-sys

Copy link
Copy Markdown
Contributor Author

Dear @vkucera ,
I will fix the warnings in my next PR .I need to present some updates urgently day after Tommorow for which I need this PR to be merged .So I kindly request you to approve this time if possible

@dmallick2
dmallick2 disabled auto-merge August 7, 2026 12:26
@dmallick2
dmallick2 enabled auto-merge (squash) August 7, 2026 12:26
@dmallick2
dmallick2 merged commit cb509c0 into AliceO2Group:master Aug 7, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

5 participants