Skip to content

[Common] Reduce verbosity of ctpRateFetcher when trigger classes are not found - #17349

Merged
ddobrigk merged 1 commit into
AliceO2Group:masterfrom
fchinu:set_log_debug
Aug 11, 2026
Merged

[Common] Reduce verbosity of ctpRateFetcher when trigger classes are not found#17349
ddobrigk merged 1 commit into
AliceO2Group:masterfrom
fchinu:set_log_debug

Conversation

@fchinu

@fchinu fchinu commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

In part of 2023 the trigger name changed, so the CMTVX-B-NOPF trigger class for some periods is not found. Both the "Trying different class" and the "class not found" message were logged at info/warn level, and since fetch() is called per collision in the TPC PID service task

hadronicRateForCollision[i] = mRateFetcher.fetch(ccdb.service, bc.timestamp(), bc.runNumber(), irSource) * 1.e-3;

this produced very large log files, causing jobs to fail because of Too much disk space used: https://alimonitor.cern.ch/agent/jobs/details.jsp?pid=3677551603
This PR demotes both messages to LOG(debug)

@github-actions github-actions Bot added the common label Aug 5, 2026
@github-actions github-actions Bot changed the title Reduce verbosity of ctpRateFetcher when trigger classes are not found [Common] Reduce verbosity of ctpRateFetcher when trigger classes are not found Aug 5, 2026
@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 4 errors, ⚠️ 1 warnings, 🔕 0 disabled

@alibuild

alibuild commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 0e07c32 at 2026-08-07 21:26:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 5 errors and 0 warnings.'
Found 5 errors and 0 warnings.
++ [[ 5 -gt 0 ]]
++ cat /sw/BUILD/ca6b292b049264555843989e8db0da9170d76e54/O2Physics-code-check/errors.txt
Common/CCDB/ctpRateFetcher.cxx:37:7: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
Common/CCDB/ctpRateFetcher.cxx:47:7: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
Common/CCDB/ctpRateFetcher.cxx:78:79: error: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
Common/CCDB/ctpRateFetcher.cxx:86:82: error: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
Common/CCDB/ctpRateFetcher.cxx:87:5: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
++ [[ 0 -gt 0 ]]
++ [[ 5 -gt 0 ]]
++ exit 1
--

Full log here.

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for 0e07c32 at 2026-08-11 10:43:

## sw/BUILD/O2Physics-latest/log
c++: fatal error: Killed signal terminated program cc1plus
c++: fatal error: Killed signal terminated program cc1plus
c++: fatal error: Killed signal terminated program cc1plus
ninja: build stopped: subcommand failed.

Full log here.

@fchinu

fchinu commented Aug 11, 2026

Copy link
Copy Markdown
Contributor Author

@dsekihat CI failures do not seem to be related to the changes implemented in this PR, do you think we can merge it? Thanks a lot!

@ddobrigk
ddobrigk merged commit c3c6b23 into AliceO2Group:master Aug 11, 2026
12 of 14 checks passed
@dsekihat

Copy link
Copy Markdown
Collaborator

Ciao @fchinu , I am sorry for my delay. It seems that I don't have approval right in this directory. Thanks to @ddobrigk for merging this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

4 participants