Skip to content

Diagnose trigger tracks selection losses in hStrangeCorrelation.cxx - #17368

Merged
romainschotter merged 2 commits into
AliceO2Group:masterfrom
kcui1:Diagnose-TriggerTracks-Selection-Losses
Aug 6, 2026
Merged

Diagnose trigger tracks selection losses in hStrangeCorrelation.cxx#17368
romainschotter merged 2 commits into
AliceO2Group:masterfrom
kcui1:Diagnose-TriggerTracks-Selection-Losses

Conversation

@kcui1

@kcui1 kcui1 commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Adds a labeled diagnostic histogram to identify the first TriggerTracks selection condition responsible for losing best-collision truth triggers.

@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 12 errors, ⚠️ 2 warnings, 🔕 0 disabled

@romainschotter
romainschotter enabled auto-merge (squash) August 6, 2026 15:35
@romainschotter
romainschotter merged commit 45438cf into AliceO2Group:master Aug 6, 2026
12 of 15 checks passed
@alibuild

alibuild commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for ad959ee at 2026-08-06 17:58:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 30 errors and 0 warnings.'
Found 30 errors and 0 warnings.
++ [[ 30 -gt 0 ]]
++ cat /sw/BUILD/2efa76f3e6ebbf3712fcdf54c9cb31c10d6d3f4a/O2Physics-code-check/errors.txt
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:95:8: error: constructor does not initialize these fields: ccdb, pdgDB [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:646:5: error: Variable 'radius' with floating point type 'double' should not be used as a loop counter [clang-analyzer-security.FloatLoopCounter,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:1022:5: error: Variable 'r' with floating point type 'double' should not be used as a loop counter [clang-analyzer-security.FloatLoopCounter,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:2673:9: error: the 'empty' method should be used to check for emptiness instead of comparing to an empty object [readability-container-size-empty,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:2851:9: error: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:2954:9: error: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:3105:9: error: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:3260:9: error: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:3345:11: error: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:3402:13: error: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:3461:13: error: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:3511:11: error: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:3614:13: error: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:3644:9: error: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:3809:26: error: redundant explicit casting to the same type 'int64_t' (aka 'long') as the sub-expression, remove this casting [readability-redundant-casting,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:3823:11: error: redundant explicit casting to the same type 'int64_t' (aka 'long') as the sub-expression, remove this casting [readability-redundant-casting,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:3856:26: error: redundant explicit casting to the same type 'int64_t' (aka 'long') as the sub-expression, remove this casting [readability-redundant-casting,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:3902:26: error: redundant explicit casting to the same type 'int64_t' (aka 'long') as the sub-expression, remove this casting [readability-redundant-casting,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:3903:30: error: redundant explicit casting to the same type 'int64_t' (aka 'long') as the sub-expression, remove this casting [readability-redundant-casting,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:3904:30: error: redundant explicit casting to the same type 'int64_t' (aka 'long') as the sub-expression, remove this casting [readability-redundant-casting,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:3958:28: error: redundant explicit casting to the same type 'int64_t' (aka 'long') as the sub-expression, remove this casting [readability-redundant-casting,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:3971:26: error: redundant explicit casting to the same type 'int64_t' (aka 'long') as the sub-expression, remove this casting [readability-redundant-casting,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:3982:28: error: redundant explicit casting to the same type 'int64_t' (aka 'long') as the sub-expression, remove this casting [readability-redundant-casting,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4325:13: error: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4332:9: error: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4390:110: error: use 'contains' to check for membership [readability-container-contains,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4456:140: error: use 'contains' to check for membership [readability-container-contains,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4612:9: error: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4642:9: error: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty,-warnings-as-errors]
PWGLF/Utils/inelGt.h:117:11: error: using integer absolute value function 'abs' when argument is of floating point type [clang-diagnostic-absolute-value,-warnings-as-errors]
++ [[ 0 -gt 0 ]]
++ [[ 30 -gt 0 ]]
++ exit 1
--

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants