Skip to content

[PWGLF] Add warning message if calibration object not found - #17402

Merged
romainschotter merged 2 commits into
masterfrom
romainschotter-patch-2
Aug 10, 2026
Merged

[PWGLF] Add warning message if calibration object not found#17402
romainschotter merged 2 commits into
masterfrom
romainschotter-patch-2

Conversation

@romainschotter

@romainschotter romainschotter commented Aug 10, 2026

Copy link
Copy Markdown
Collaborator

Add warning message if strangeness TOF PID calibration objects are not found

@ariedel-cern for your information

@github-actions github-actions Bot added the pwglf label Aug 10, 2026
@github-actions github-actions Bot changed the title Add warning message if calibration object not found [PWGLF] Add warning message if calibration object not found Aug 10, 2026
@github-actions

github-actions Bot commented Aug 10, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 23 errors, ⚠️ 33 warnings, 🔕 0 disabled

@alibuild alibuild mentioned this pull request Aug 10, 2026
Merged
@romainschotter
romainschotter marked this pull request as ready for review August 10, 2026 17:40
@romainschotter
romainschotter enabled auto-merge (squash) August 10, 2026 17:40
alibuild
alibuild approved these changes Aug 10, 2026
View reviewed changes

@alibuild alibuild left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @romainschotter.

@alibuild

alibuild commented Aug 10, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for fcb8921 at 2026-08-10 19:57:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 86 errors and 14 warnings.'
Found 86 errors and 14 warnings.
++ [[ 86 -gt 0 ]]
++ cat /sw/BUILD/c949a328f93e1909f0272e9eac68bbcefe38ea88/O2Physics-code-check/errors.txt
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:91:8: error: constructor does not initialize these fields: ccdb, mTOFResponse, nSigmaCalibLoaded, mRunNumber, d_bz, maxSnp, maxStep [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:221:18: error: member 'bcShiftValuePS' of type 'const double' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:281:5: error: uninitialized record type: 'mom' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:284:5: error: uninitialized record type: 'startPoint' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:293:11: error: variable 'sna' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:293:16: error: variable 'csa' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:399:28: error: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:406:33: error: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:413:34: error: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:420:35: error: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:427:36: error: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:434:36: error: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:442:37: error: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:449:42: error: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:637:5: error: use auto when initializing with a template cast to avoid duplicating the type name [modernize-use-auto,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:638:43: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:675:15: error: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:676:28: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:677:28: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:678:28: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:679:28: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:680:28: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:681:28: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:683:29: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:684:29: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:685:29: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:686:29: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:687:29: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:688:29: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:707:15: error: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:708:28: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:709:28: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:710:28: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:711:28: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:712:29: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:713:28: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:714:28: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:715:28: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:716:28: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:717:29: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:719:29: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/strangenesstofpid.cxx:720:29: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
[0 more errors; see full log]

Full log here.

@romainschotter
romainschotter merged commit 92ecad5 into master Aug 10, 2026
12 of 16 checks passed
@romainschotter
romainschotter deleted the romainschotter-patch-2 branch August 10, 2026 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alibuild alibuild alibuild approved these changes
@omvazque omvazque Awaiting requested review from omvazque omvazque is a code owner
@mpuccio mpuccio Awaiting requested review from mpuccio mpuccio is a code owner
@skundu692 skundu692 Awaiting requested review from skundu692 skundu692 is a code owner
@ercolessi ercolessi Awaiting requested review from ercolessi ercolessi is a code owner
@lhusova lhusova Awaiting requested review from lhusova lhusova is a code owner

Assignees

No one assigned

Labels

pwglf

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@romainschotter @alibuild