Skip to content

Conversation

@vkucera
Copy link
Collaborator

@vkucera vkucera commented Nov 11, 2024

No description provided.

@github-actions github-actions bot added the dpg label Nov 11, 2024
@github-actions github-actions bot changed the title Fix compilation warnings [DPG] Fix compilation warnings Nov 11, 2024
@vkucera
Copy link
Collaborator Author

vkucera commented Nov 12, 2024

@ekryshen @strogolo @chiarazampolli @noferini Can you please review?

@vkucera
Copy link
Collaborator Author

vkucera commented Nov 14, 2024

@ekryshen @strogolo @chiarazampolli @noferini Can you please review?

Ping

@ekryshen
Copy link
Collaborator

@vkucera Thanks for taking care of the warnings. The changes are fine with me.

@ekryshen
Copy link
Collaborator

I have no approval rights for qaFV0.cxx. @chiarazampolli @noferini could you approve it?

@ekryshen ekryshen enabled auto-merge (squash) November 14, 2024 09:04
@vkucera
Copy link
Collaborator Author

vkucera commented Nov 15, 2024

@chiarazampolli @noferini Ping

@noferini
Copy link
Collaborator

Hi @vkucera ,
just to say I am no longer allowed to authorize on behalf of DPG.
Cheers,
Francesco

@vkucera
Copy link
Collaborator Author

vkucera commented Nov 18, 2024

Hi @vkucera , just to say I am no longer allowed to authorize on behalf of DPG. Cheers, Francesco

Hi @noferini , can you please clarify what it means? You are listed as a code owner of the DPG directory and you also have write access in the repository.

@vkucera
Copy link
Collaborator Author

vkucera commented Nov 18, 2024

@chiarazampolli the PR has been pending for a week now. Is there a problem approving it?

@noferini
Copy link
Collaborator

Hi @vkucera , just to say I am no longer allowed to authorize on behalf of DPG. Cheers, Francesco

Hi @noferini , can you please clarify what it means? You are listed as a code owner of the DPG directory and you also have write access in the repository.

Hi, I am no longer in the DPG coordination. At some point rights will be removed and assigned to somebody else.
Cheers,
Francesco

@vkucera
Copy link
Collaborator Author

vkucera commented Nov 18, 2024

Hi @vkucera , just to say I am no longer allowed to authorize on behalf of DPG. Cheers, Francesco

Hi @noferini , can you please clarify what it means? You are listed as a code owner of the DPG directory and you also have write access in the repository.

Hi, I am no longer in the DPG coordination. At some point rights will be removed and assigned to somebody else. Cheers, Francesco

OK, thanks for the clarification.

@ekryshen ekryshen merged commit 884d8a4 into AliceO2Group:master Nov 19, 2024
@chiarazampolli
Copy link
Collaborator

Sorry, I overlooked this. Approved now, all looks good to me too.

@vkucera vkucera deleted the DPG-warnings branch November 19, 2024 15:04
christianreckziegel pushed a commit to christianreckziegel/O2Physics that referenced this pull request Nov 19, 2024
joachimckh pushed a commit to joachimckh/O2Physics that referenced this pull request Dec 2, 2024
joachimckh pushed a commit to joachimckh/O2Physics that referenced this pull request Dec 2, 2024
feisenhu pushed a commit to feisenhu/O2Physics that referenced this pull request Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

4 participants