Adding Laser Aging Task with adjustable amplitude cut#1990
Closed
sandor-lokos wants to merge 4 commits into
Closed
Adding Laser Aging Task with adjustable amplitude cut#1990sandor-lokos wants to merge 4 commits into
sandor-lokos wants to merge 4 commits into
Conversation
…bility to cut on amplitudes from config
Comment on lines
+120
to
+123
| unsigned int costumAmplCut = 0; | ||
| for (const auto& cutAmpl : mSetAmpCut) { | ||
| costumAmplCut = cutAmpl; | ||
| } |
Collaborator
There was a problem hiding this comment.
I think some change is needed here, either the amp cut is channel wise or it is not?
andreasmolander
approved these changes
Sep 18, 2023
knopers8
requested changes
Sep 19, 2023
Collaborator
knopers8
left a comment
knopers8
left a comment
There was a problem hiding this comment.
I have only some suggestions regarding adherence to the O2 coding guidelines and removing the leftovers from the class skeleton.
Comment on lines
+28
to
+45
| #include "TH1.h" | ||
| #include "TH2.h" | ||
| #include "TList.h" | ||
| #include "Rtypes.h" | ||
|
|
||
| #include <Framework/InputRecord.h> | ||
| #include "CommonConstants/LHCConstants.h" | ||
| #include "QualityControl/TaskInterface.h" | ||
| #include "QualityControl/QcInfoLogger.h" | ||
| #include "FT0Base/Constants.h" | ||
| #include "FT0Base/Geometry.h" | ||
| #include "DataFormatsFT0/Digit.h" | ||
| #include "DataFormatsFT0/ChannelData.h" | ||
|
|
||
| #include "TH1.h" | ||
| #include "TH2.h" | ||
| #include "TList.h" | ||
| #include "Rtypes.h" |
Collaborator
There was a problem hiding this comment.
Suggested change
| #include "TH1.h" | |
| #include "TH2.h" | |
| #include "TList.h" | |
| #include "Rtypes.h" | |
| #include <Framework/InputRecord.h> | |
| #include "CommonConstants/LHCConstants.h" | |
| #include "QualityControl/TaskInterface.h" | |
| #include "QualityControl/QcInfoLogger.h" | |
| #include "FT0Base/Constants.h" | |
| #include "FT0Base/Geometry.h" | |
| #include "DataFormatsFT0/Digit.h" | |
| #include "DataFormatsFT0/ChannelData.h" | |
| #include "TH1.h" | |
| #include "TH2.h" | |
| #include "TList.h" | |
| #include "Rtypes.h" | |
| #include <Framework/InputRecord.h> | |
| #include <CommonConstants/LHCConstants.h> | |
| #include "QualityControl/TaskInterface.h" | |
| #include "QualityControl/QcInfoLogger.h" | |
| #include <FT0Base/Constants.h> | |
| #include <FT0Base/Geometry.h> | |
| #include <DataFormatsFT0/Digit.h> | |
| #include <DataFormatsFT0/ChannelData.h> | |
| #include <TH1.h> | |
| #include <TH2.h> | |
| #include <TList.h> | |
| #include <Rtypes.h> |
| // granted to it by virtue of its status as an Intergovernmental Organization | ||
| // or submit itself to any jurisdiction. | ||
| /// \file LaserAgingFT0Task.cxx | ||
| /// \author My Name |
Collaborator
There was a problem hiding this comment.
Suggested change
| /// \author My Name | |
| /// \author Sandor Lokos |
Comment on lines
+36
to
+39
| // THUS FUNCTION BODY IS AN EXAMPLE. PLEASE REMOVE EVERYTHING YOU DO NOT NEED. | ||
| ILOG(Debug, Devel) << "initialize LaserAgingFT0Task" << ENDM; // QcInfoLogger is used. FairMQ logs will go to there as well. | ||
| ILOG(Debug, Support) << "Debug" << ENDM; // QcInfoLogger is used. FairMQ logs will go to there as well. | ||
| ILOG(Info, Support) << "Info" << ENDM; // QcInfoLogger is used. FairMQ logs will go to there as well. |
Collaborator
There was a problem hiding this comment.
Suggested change
| // THUS FUNCTION BODY IS AN EXAMPLE. PLEASE REMOVE EVERYTHING YOU DO NOT NEED. | |
| ILOG(Debug, Devel) << "initialize LaserAgingFT0Task" << ENDM; // QcInfoLogger is used. FairMQ logs will go to there as well. | |
| ILOG(Debug, Support) << "Debug" << ENDM; // QcInfoLogger is used. FairMQ logs will go to there as well. | |
| ILOG(Info, Support) << "Info" << ENDM; // QcInfoLogger is used. FairMQ logs will go to there as well. | |
| ILOG(Debug, Devel) << "initialize LaserAgingFT0Task" << ENDM; |
from all of this, you probably need just that
Comment on lines
+106
to
+109
| for (auto& entry : mMapHistAmpVsBCADC0) | ||
| entry.second->Reset(); | ||
| for (auto& entry : mMapHistAmpVsBCADC1) | ||
| entry.second->Reset(); |
Collaborator
There was a problem hiding this comment.
Suggested change
| for (auto& entry : mMapHistAmpVsBCADC0) | |
| entry.second->Reset(); | |
| for (auto& entry : mMapHistAmpVsBCADC1) | |
| entry.second->Reset(); | |
| for (auto& entry : mMapHistAmpVsBCADC0) { | |
| entry.second->Reset(); | |
| } | |
| for (auto& entry : mMapHistAmpVsBCADC1) { | |
| entry.second->Reset(); | |
| } |
https://rawgit.com/AliceO2Group/CodingGuidelines/master/naming_formatting.html?showone=Braces#Braces
|
|
||
| void LaserAgingFT0Task::startOfActivity(const Activity& activity) | ||
| { | ||
| // THUS FUNCTION BODY IS AN EXAMPLE. PLEASE REMOVE EVERYTHING YOU DO NOT NEED. |
Collaborator
There was a problem hiding this comment.
Suggested change
| // THUS FUNCTION BODY IS AN EXAMPLE. PLEASE REMOVE EVERYTHING YOU DO NOT NEED. |
Comment on lines
+130
to
+133
| if (chData.getFlag(o2::ft0::ChannelData::kNumberADC)) | ||
| mHistAmp2ADC1->Fill(static_cast<Double_t>(chData.ChId), static_cast<Double_t>(chData.QTCAmpl)); | ||
| else | ||
| mHistAmp2ADC0->Fill(static_cast<Double_t>(chData.ChId), static_cast<Double_t>(chData.QTCAmpl)); |
Collaborator
There was a problem hiding this comment.
Suggested change
| if (chData.getFlag(o2::ft0::ChannelData::kNumberADC)) | |
| mHistAmp2ADC1->Fill(static_cast<Double_t>(chData.ChId), static_cast<Double_t>(chData.QTCAmpl)); | |
| else | |
| mHistAmp2ADC0->Fill(static_cast<Double_t>(chData.ChId), static_cast<Double_t>(chData.QTCAmpl)); | |
| if (chData.getFlag(o2::ft0::ChannelData::kNumberADC)) { | |
| mHistAmp2ADC1->Fill(static_cast<Double_t>(chData.ChId), static_cast<Double_t>(chData.QTCAmpl)); | |
| } | |
| else { | |
| mHistAmp2ADC0->Fill(static_cast<Double_t>(chData.ChId), static_cast<Double_t>(chData.QTCAmpl)); | |
| } |
Comment on lines
+161
to
+164
| // THUS FUNCTION BODY IS AN EXAMPLE. PLEASE REMOVE EVERYTHING YOU DO NOT NEED. | ||
|
|
||
| // clean all the monitor objects here | ||
|
|
Collaborator
There was a problem hiding this comment.
Suggested change
| // THUS FUNCTION BODY IS AN EXAMPLE. PLEASE REMOVE EVERYTHING YOU DO NOT NEED. | |
| // clean all the monitor objects here |
| if (auto histo = dynamic_cast<TH2F*>(obj)) { | ||
| int channel = -1; | ||
| sscanf(histo->GetName(), "%*[^0-9]%d", &channel); | ||
| std::cerr << histo << std::endl; |
Collaborator
There was a problem hiding this comment.
Suggested change
| std::cerr << histo << std::endl; |
Please avoid using directly stderr, this will be anyway redirected to infologger, but as warnings.
| } | ||
| } | ||
| } // namespace o2::quality_control_modules::ft0 | ||
| // ILOG(Warning)<<histo->GetName()<<" entries: "<< bc_projection->GetEntries()<<" channel: "<<channel<<" ibc: "<<ibc<<" ibc_max: "<<ibc_max<<ENDM; |
Collaborator
There was a problem hiding this comment.
Suggested change
| // ILOG(Warning)<<histo->GetName()<<" entries: "<< bc_projection->GetEntries()<<" channel: "<<channel<<" ibc: "<<ibc<<" ibc_max: "<<ibc_max<<ENDM; |
Comment on lines
+52
to
+53
| if (stdv < 0.5) | ||
| stdv = 0.5; |
Collaborator
There was a problem hiding this comment.
Suggested change
| if (stdv < 0.5) | |
| stdv = 0.5; | |
| if (stdv < 0.5) { | |
| stdv = 0.5; | |
| } |
Collaborator
|
No need to merge yet. We noticed more changes are needed, I will take care of these, including Piotr's points. |
Collaborator
|
Closing as the functionality was included in: #2130 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aging monitoring task is implemented with an additional configurable parameter that perform cut on the amplitude.