FT0: add task for aging monitoring#2130
Merged
Merged
Conversation
This is a combination of 10 commits. Development done by Andreas Molander, Sandor Lokos and Edmundo Garcia-Solis. Commit messages: Aging monitoring with laser task implemented with an additional possibility to cut on amplitudes from config CLang corrections done Revision after MAC build fail Mac build issue resolved FT0: adapt to O2 coding guidelines and remove skeleton leftovers [WIP] FT0: Refactor aging monitoring QC task - Some general refactoring, renaming etc. - Produce additional histograms (some only for debug, to be reviewed) - Delete obsolete stuff [WIP] FT0: Refactor and add time histos in aging monitoring task [WIP] FT0: refactor aging monitoring task [WIP] FT0: minor fixes to aging QC + add README [WIP] FT0: Clean up debug conditions in aging QC
andreasmolander
force-pushed
the
ft0AgingSquash
branch
from
130ff42 to
e012da5
Compare
Collaborator
Author
|
Hello @jotwinow @afurs @knopers8 @Barthelemy, Please have a look. It looks like codeowners of Modules/FIT are not pinged on changes in sub directories? I think it looks like the failing tests are not related to this? |
Collaborator
|
@andreasmolander It seems that people in the codeowner must have write access to the repo. I have added you. Be carefule please :-) |
Collaborator
|
spurious errors, merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a combination of 10 commits.
Development done by Andreas Molander, Sandor Lokos and Edmundo Garcia-Solis. Commit messages:
Aging monitoring with laser task implemented with an additional possibility to cut on amplitudes from config
CLang corrections done
Revision after MAC build fail
Mac build issue resolved
FT0: adapt to O2 coding guidelines and remove skeleton leftovers
[WIP] FT0: Refactor aging monitoring QC task
[WIP] FT0: Refactor and add time histos in aging monitoring task
[WIP] FT0: refactor aging monitoring task
[WIP] FT0: minor fixes to aging QC + add README
[WIP] FT0: Clean up debug conditions in aging QC