Skip to content

TPC: rawDataQA#694

Merged
Barthelemy merged 1 commit into
AliceO2Group:masterfrom
tklemenz:rawQA
May 11, 2021
Merged

TPC: rawDataQA#694
Barthelemy merged 1 commit into
AliceO2Group:masterfrom
tklemenz:rawQA

Conversation

@tklemenz
Copy link
Copy Markdown
Contributor

Add a QC task for TPC raw digits

@tklemenz
Copy link
Copy Markdown
Contributor Author

The o2-dataflow build error seems unrelated to the PR.

@Barthelemy
Copy link
Copy Markdown
Collaborator

Indeed, the o2-dataflow is due to something else (we need to move to gcc10). The macOS is strange as there is nothing. Let's see.

@tklemenz
Copy link
Copy Markdown
Contributor Author

tklemenz commented May 10, 2021

Is gcc10 the solution? I am getting similar complaints about #include <filesystem> on my local machine when compiling the latest O2 dev but QualityControl master builds without error.

@Barthelemy
Copy link
Copy Markdown
Collaborator

Do you have gcc 10 ?
The probem here is that o2-dataflow uses gcc 7 and filesystem was still in experimental back then.

@tklemenz
Copy link
Copy Markdown
Contributor Author

I am on gcc 7.5.0

@Barthelemy
Copy link
Copy Markdown
Collaborator

Then this is why you have this issue. If you use the defaults o2 then it will force gcc10. It is not yet hte case with o2-dataflow and it provokes this error. We are working on it: alisw/alidist#3027

@tklemenz
Copy link
Copy Markdown
Contributor Author

tklemenz commented May 10, 2021

This is weird, because on my local machine I do use --defaults o2.
aliBuild build QualityControl --defaults o2

gcc 7.5.0 is my system gcc. But then it seems to me that aliBuild doesn't force gcc 10.

@Barthelemy
Copy link
Copy Markdown
Collaborator

Are you sure that your alidist is up to date ? Because defaults-o2.sh reads:

overrides:
  GCC-Toolchain:
     version: "v10.2.0-alice2"
     tag: "v10.2.0-alice2"

@tklemenz
Copy link
Copy Markdown
Contributor Author

tklemenz commented May 10, 2021

Yes, this is exactly what I see in my defaults-o2.sh, too.

overrides:
  GCC-Toolchain:
     version: "v10.2.0-alice2"
     tag: "v10.2.0-alice2"

Maybe for some reason gcc 10 was skipped during building. I'll find a way, I guess. At least I know now what the origin of the problem is.

@stheckel
Copy link
Copy Markdown
Contributor

Hi,
I observe the same behaviour as Thomas concerning the gcc: I have aliBuild version 1.8.0 and alidist/O2/QC (master or dev) from Friday (May 7) morning. Compiling O2 and QC with
aliBuild build QualityControl --defaults o2
gcc is not compiled, but taken from the system, and the system version is 7.5.0. At least, when loading QC (and hence O2) and typing gcc --version I get the 7.5.0.
As Thomas I am on Ubuntu 18.04.

@tklemenz
Copy link
Copy Markdown
Contributor Author

tklemenz commented May 11, 2021

FYI: I changed the required version of gcc in gcc-toolchain.sh and it worked.

case $REQUESTED_VERSION in
  v10*) MIN_GCC_VERSION=100200 ;;
  *) MIN_GCC_VERSION=100200 ;;          # <---------------- HERE
esac

@Barthelemy
Copy link
Copy Markdown
Collaborator

@ktf Is it expected that gcc 7 is picked from the system ? should we not enforce gcc 10 ?

@ktf
Copy link
Copy Markdown
Member

ktf commented May 11, 2021

@Barthelemy alibuild will pick up GCC 10.2 from the system only if such a version is requested in GCC-ToolChain (i.e. not for aliphysics).

@Barthelemy
Copy link
Copy Markdown
Collaborator

@ktf But I don't think that Thomas is using aliphysics. Any ways, I think that it should go to another thread. Thomas, could you open a JIRA ticket ?

@Barthelemy
Copy link
Copy Markdown
Collaborator

the macOS build seems spurrious., merging.

@Barthelemy Barthelemy merged commit 32092de into AliceO2Group:master May 11, 2021
@ktf
Copy link
Copy Markdown
Member

ktf commented May 11, 2021

I mean that the reason why we still have 7.3.0 is due to AliPhysics.

@tklemenz
Copy link
Copy Markdown
Contributor Author

Sure, I can open a ticket and yes, I do not use aliphysics.

@tklemenz
Copy link
Copy Markdown
Contributor Author

The ticket can be found here: https://alice.its.cern.ch/jira/browse/O2-2327

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants