Skip to content

Enable GCC 10 in dataflow defaults#3027

Merged
awegrzyn merged 1 commit into
masterfrom
gcc-10-dataflow
May 10, 2021
Merged

Enable GCC 10 in dataflow defaults#3027
awegrzyn merged 1 commit into
masterfrom
gcc-10-dataflow

Conversation

@awegrzyn
Copy link
Copy Markdown
Contributor

No description provided.

@awegrzyn awegrzyn requested a review from a team as a code owner May 10, 2021 08:19
@awegrzyn awegrzyn requested review from Barthelemy and ktf May 10, 2021 08:19
Copy link
Copy Markdown
Contributor

@davidrohr davidrohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx :)

@awegrzyn
Copy link
Copy Markdown
Contributor Author

awegrzyn commented May 10, 2021

For FLP Suite v0.18.x releases we do have a dedicated branch so this applies from v0.19.0

@awegrzyn
Copy link
Copy Markdown
Contributor Author

@ktf Could you remove devtoolset section from https://alice-doc.github.io/alice-analysis-tutorial/building/prereq-centos7.html ?

@ktf
Copy link
Copy Markdown
Member

ktf commented May 10, 2021

@awegrzyn done in alice-doc/alice-analysis-tutorial#130. We should probably revisit those instructions completely.

@davidrohr
Copy link
Copy Markdown
Contributor

@Barthelemy @awegrzyn : o2/alidist-dataflow is green, can I merge it?

@awegrzyn awegrzyn merged commit a6caf74 into master May 10, 2021
@awegrzyn awegrzyn deleted the gcc-10-dataflow branch May 10, 2021 17:44
ironMann pushed a commit to ironMann/alidist that referenced this pull request May 10, 2021
@Barthelemy
Copy link
Copy Markdown
Contributor

That went a lot smoother than I expected !

@awegrzyn
Copy link
Copy Markdown
Contributor Author

On my setup I get No package 'capstone' found and then parallel_backend_tbb.h:28:6: error: #error Intel(R) Threading Building Blocks 2018 is required, any ideas?

@davidrohr
Copy link
Copy Markdown
Contributor

For the TBB thing, without knowing fully for sure: GCC uses TBB if avaiable for its std::parallel stuff. That is decided at compile time. So when you compile GCC on a system with TBB headers available, and then copy it to a system without TBB headers, one might get the error you see. Though not 100% sure if it is that, but since you mention parallel_backend_tbb.h, I'd say I am 99% sure :)
No idea for capstone.

@awegrzyn
Copy link
Copy Markdown
Contributor Author

Sorry, forgot to mention that this happens when compiling DebugGUI

@davidrohr
Copy link
Copy Markdown
Contributor

Ah, ok, so then the problem might be: You probably have a TBB installed, but an older version than what is required by GCC. DebugGUI contains tracy, which has some logic to detect tbb. It probably finds the old version and tries to use it, and then GCC fails to compile with it.
Ping @ktf

@ktf
Copy link
Copy Markdown
Member

ktf commented May 11, 2021

Yes, I am trying to update Tracy to see if that fixes the problem/

ironMann pushed a commit to ironMann/alidist that referenced this pull request May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants